Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(health): do not require auth for /healthz and /readyz #3656

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

mudler
Copy link
Owner

@mudler mudler commented Sep 24, 2024

Description

This PR fixes #3655

Notes for Reviewers

Introduced in #3476

Signed commits

  • Yes, I signed my commits.

@mudler mudler added the bug Something isn't working label Sep 24, 2024
Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for localai ready!

Name Link
🔨 Latest commit fa3b907
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/66f2ea9458e6940009b8d454
😎 Deploy Preview https://deploy-preview-3656--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Adding a reminder here...
Copy link
Collaborator

@dave-gray101 dave-gray101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment so I remember why we did this... otherwise looks sound to me

@@ -121,6 +121,9 @@ func App(cl *config.BackendConfigLoader, ml *model.ModelLoader, appConfig *confi
})
}

// Health Checks should always be exempt from auth, so register these first
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mudler mudler enabled auto-merge (squash) September 24, 2024 16:37
@mudler mudler merged commit 0893d3c into master Sep 24, 2024
31 checks passed
@mudler mudler deleted the healthcheck_api branch September 24, 2024 18:26
truecharts-admin referenced this pull request in truecharts/public Sep 25, 2024
…1.1 by renovate (#26865)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[docker.io/localai/localai](https://redirect.github.com/mudler/LocalAI)
| patch | `v2.21.0-cublas-cuda11-core` -> `v2.21.1-cublas-cuda11-core` |
|
[docker.io/localai/localai](https://redirect.github.com/mudler/LocalAI)
| patch | `v2.21.0-cublas-cuda12-core` -> `v2.21.1-cublas-cuda12-core` |
|
[docker.io/localai/localai](https://redirect.github.com/mudler/LocalAI)
| patch | `v2.21.0` -> `v2.21.1` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>mudler/LocalAI (docker.io/localai/localai)</summary>

###
[`v2.21.1`](https://redirect.github.com/mudler/LocalAI/releases/tag/v2.21.1)

[Compare
Source](https://redirect.github.com/mudler/LocalAI/compare/v2.21.0...v2.21.1)

<!-- Release notes generated using configuration in .github/release.yml
at master -->

##### What's Changed

##### Bug fixes 🐛

- fix(health): do not require auth for /healthz and /readyz by
[@&#8203;mudler](https://redirect.github.com/mudler) in
[https://github.com/mudler/LocalAI/pull/3656](https://redirect.github.com/mudler/LocalAI/pull/3656)

##### 👒 Dependencies

- chore(deps): Bump sentence-transformers from 3.1.0 to 3.1.1 in
/backend/python/sentencetransformers by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/mudler/LocalAI/pull/3651](https://redirect.github.com/mudler/LocalAI/pull/3651)
- chore(deps): Bump pydantic from 2.8.2 to 2.9.2 in
/examples/langchain/langchainpy-localai-example by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/mudler/LocalAI/pull/3648](https://redirect.github.com/mudler/LocalAI/pull/3648)
- chore(deps): Bump openai from 1.45.1 to 1.47.1 in /examples/functions
by [@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/mudler/LocalAI/pull/3645](https://redirect.github.com/mudler/LocalAI/pull/3645)
- chore: ⬆️ Update ggerganov/llama.cpp to
`70392f1f81470607ba3afef04aa56c9f65587664` by
[@&#8203;localai-bot](https://redirect.github.com/localai-bot) in
[https://github.com/mudler/LocalAI/pull/3659](https://redirect.github.com/mudler/LocalAI/pull/3659)
- chore(deps): Bump llama-index from 0.11.7 to 0.11.12 in
/examples/langchain-chroma by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/mudler/LocalAI/pull/3639](https://redirect.github.com/mudler/LocalAI/pull/3639)
- chore(deps): Bump openai from 1.45.1 to 1.47.1 in
/examples/langchain-chroma by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/mudler/LocalAI/pull/3641](https://redirect.github.com/mudler/LocalAI/pull/3641)
- chore(deps): Bump llama-index from 0.11.9 to 0.11.12 in
/examples/chainlit by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/mudler/LocalAI/pull/3642](https://redirect.github.com/mudler/LocalAI/pull/3642)
- chore: ⬆️ Update ggerganov/whisper.cpp to
`0d2e2aed80109e8696791083bde3b58e190b7812` by
[@&#8203;localai-bot](https://redirect.github.com/localai-bot) in
[https://github.com/mudler/LocalAI/pull/3658](https://redirect.github.com/mudler/LocalAI/pull/3658)
- chore(deps): Bump chromadb from 0.5.5 to 0.5.7 in
/examples/langchain-chroma by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/mudler/LocalAI/pull/3640](https://redirect.github.com/mudler/LocalAI/pull/3640)

##### Other Changes

- docs: ⬆️ update docs version mudler/LocalAI by
[@&#8203;localai-bot](https://redirect.github.com/localai-bot) in
[https://github.com/mudler/LocalAI/pull/3657](https://redirect.github.com/mudler/LocalAI/pull/3657)

**Full Changelog**:
mudler/LocalAI@v2.21.0...v2.21.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC45NS4zIiwidXBkYXRlZEluVmVyIjoiMzguOTUuMyIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6WyJhdXRvbWVyZ2UiLCJ1cGRhdGUvZG9ja2VyL2dlbmVyYWwvbm9uLW1ham9yIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERR Server error error="missing or malformed API Key"
2 participants