Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telegram-bot example: Update LocalAI version (fixes #2638) #2640

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

greygoo
Copy link
Contributor

@greygoo greygoo commented Jun 23, 2024

Description

This PR fixes #2638

Notes for Reviewers
Tested image and text generation. All bugs found in the previous version remain but #2638, no regression was found while doing exploratory testing.

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Jun 23, 2024

Deploy Preview for localai ready!

Name Link
🔨 Latest commit 6515b6c
🔍 Latest deploy log https://app.netlify.com/sites/localai/deploys/667d5ca2c83ad00008be3e3b
😎 Deploy Preview https://deploy-preview-2640--localai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@greygoo
Copy link
Contributor Author

greygoo commented Jun 23, 2024

Will sign asap, just need to set it up first.

@@ -2,7 +2,7 @@ version: "3"

services:
api:
image: quay.io/go-skynet/local-ai:v1.18.0-ffmpeg
image: quay.io/go-skynet/local-ai:v2.17.1-ffmpeg
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, good catch - since we are here maybe worth switching to use latest so we don't have to keep that up-to-date?

Suggested change
image: quay.io/go-skynet/local-ai:v2.17.1-ffmpeg
image: quay.io/go-skynet/local-ai:latest-ffmpeg

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was also thinking about that. Let me test with the latest tomorrow and then redo the PR, and also sign it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no quay.io/go-skynet/local-ai:latest-ffmpeg - I tested with quay.io/go-skynet/local-ai:latest-cpu

 ✘ api Error manifest for quay.io/go-skynet/local-ai:latest-ffmpeg not found: manifest unknown: manifest unknown                                                                                                                                          2.0s 
Error response from daemon: manifest for quay.io/go-skynet/local-ai:latest-ffmpeg not found: manifest unknown: manifest unknown

So far everything worked as before, which makes me wonder what the purpose is behind choosing ffmpeg. I fear something I'm not aware of might break. Where would I look/test to check?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch sorry, yes, there is only :latest, or :latest-ffmpeg-core

@mudler mudler merged commit 20ec4d0 into mudler:master Jun 27, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error generating a image with the telegram-bot example (stablediffusion)
2 participants