feat(metrics): Adding initial support for prometheus metrics #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudler
previously approved these changes
Oct 16, 2023
mudler
approved these changes
Oct 17, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial PR to add the initial support for Prometheus metrics. It only adds one metric for API calls duration. We need to figure out what we want to expose in the metrics.
For this PR I'm using OpenTelemetry library, but I'm focusing on exposing the Prometheus metrics. In the future we can expand that with other Metrics format and add Tracing if we considere it interesting.
This PR fixes #519
Here is a screenshot of some metrics collected quicly
