Feature/9 add use resize observer hook #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pigeonfresh
approved these changes
May 3, 2022
| <p>Resize the window or click on the resize button to see the events being triggered.</p> | ||
| <p class="mb-0"> | ||
| Note: The <code>callback</code> is debounced by <u>100ms</u> to avoid it from being called | ||
| way too much for the sake of the demo. |
ThaNarie
requested changes
May 3, 2022
| addToResizeObserver(source, debouncedCallback); | ||
| }); | ||
|
|
||
| onUnmounted(() => { |
There was a problem hiding this comment.
This should not be needed anymore, watch and watchEffect are automatically cleaned up since alpha.31:
Proxy
watch/watchEffectto allow auto-cleanup on component unmount – no need to clean these up yourself anymore.
| }); | ||
| } else { | ||
| const removeWatchEffect = watchEffect(() => { | ||
| removeFromResizeObserver(source); |
There was a problem hiding this comment.
You could use the onCleanup instead: https://vuejs.org/api/reactivity-core.html#watcheffect
That would also make sure you don't need the onUnmounted below.
Just like in react where you return a dispose function from the hook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
useResizeObserverhook and close #9