Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr Changes #54

Closed
wants to merge 9 commits into from
Closed

Pr Changes #54

wants to merge 9 commits into from

Conversation

Sammy1Am
Copy link

@Sammy1Am Sammy1Am commented Aug 9, 2024

These changes address some of the feedback from the PR. Notably:

  • Remove default name
  • Use time_id
  • Don't depend or auto_load climate
  • Sensors, buttons, and selects are broken out into their own directories/files.

These changes do not address:

  • Avoiding AUTO_LOAD by making the sensors listeners (will begin work on this now)
  • Moving from a climate-hub to a climate component and separate hub (unclear yet if this is reasonable / feasible)

@Sammy1Am Sammy1Am requested a review from KazWolfe as a code owner August 9, 2024 22:03
@Sammy1Am Sammy1Am closed this Aug 10, 2024
@Sammy1Am Sammy1Am deleted the pr-changes branch August 12, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazWolfe KazWolfe Awaiting requested review from KazWolfe KazWolfe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Sammy1Am