Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes sure to free a pointer we own #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Makes sure to free a pointer we own #19

wants to merge 1 commit into from

Conversation

alindeman
Copy link
Contributor

Fixes #18

@alindeman alindeman mentioned this pull request Oct 20, 2014
Closed
@alindeman
Copy link
Contributor Author

@mtodd: This seem OK?

@mtodd
Copy link
Owner

mtodd commented Oct 21, 2014

@alindeman should the change should be applied to rb_geoip_org_look_up et al as well?

@alindeman
Copy link
Contributor Author

@alindeman should the change should be applied to rb_geoip_org_look_up et al as well?

Yes, somehow I missed these, nice catch. Added a new commit to deal with those.

@kaspergrubbe
Copy link

@mtodd Can we get these changes merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alindeman @mtodd @kaspergrubbe