-
-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revert the lazy import of graphql
#2298
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this, @grebenyuksv. Can you please remind me what issue are you facing with the dynamic I have a suspicion that merging this will cause errors for ESM consumers. Importing anything from the root results in an import to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Thank you, @grebenyuksv.
I confirm this is how it used to be before the lazy-loading disaster (ref).
graphql
graphql
I'm concerned that this change will make #2248 an issue again. Perhaps we should take a closer look at why your use case errors, @grebenyuksv. |
Thanks for your review, @kettanaito! Let's close it for now. I've parked that Storybook project where the dynamic import doesn't work and, as I said, I would rather bet that the problem is in other tooling, not in MSW. |
This reverts the recent attempts to import
graphql
lazily, which we agreed to do in #2250 (comment).