Allow to use args in editor option

mstrzele · Aug 9, 2017 · 02526ef · 02526ef
1 parent 5455432
commit 02526ef
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/edit.go b/edit.go
@@ -6,6 +6,7 @@ import (
 	"io/ioutil"
 	"os"
 	"os/exec"
+	"strings"
 
 	"github.com/spf13/cobra"
 
@@ -94,7 +95,9 @@ func (e *editCmd) run() error {
 		return err
 	}
 
-	cmd := exec.Command(e.editor, tmpfile.Name())
+	editor := strings.Split(e.editor, " ")
+
+	cmd := exec.Command(editor[0], append(editor[1:], tmpfile.Name())...)
 	cmd.Stdin = os.Stdin
 	cmd.Stdout = e.out
 	cmd.Stderr = e.out

diff --git a/install.sh b/install.sh
@@ -2,7 +2,7 @@
 
 set -euf -o pipefail
 
-HELM_EDIT_VERSION=${HELM_EDIT_VERSION:-"0.1.0"}
+HELM_EDIT_VERSION=${HELM_EDIT_VERSION:-"0.1.1"}
 
 file="${HELM_PLUGIN_DIR:-"$(helm home)/plugins/helm-edit"}/helm-edit"
 os=$(uname -s | tr '[:upper:]' '[:lower:]')