Set PRODID when we create a vcard from roundcube data

mstilkerich · Aug 15, 2022 · 1a2cbb4 · 1a2cbb4
1 parent 1179f37
commit 1a2cbb4
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## Version 4.4.3 (to 4.4.2)
 
 - Properly set and interpret TYPE parameters, especially for TEL (Fixes #390)
+- RCMCardDAV now sets the PRODID property when it creates or modifies a vcard
 
 ## Version 4.4.2 (to 4.4.1)
 

diff --git a/carddav.php b/carddav.php
@@ -71,7 +71,7 @@ class carddav extends rcube_plugin
      *
      * During development, it is set to the last release and added the suffix +dev.
      */
-    private const PLUGIN_VERSION = 'v4.4.2+dev';
+    public const PLUGIN_VERSION = 'v4.4.2+dev';
 
     /**
      * Information about this plugin that is queried by roundcube.

diff --git a/src/DataConversion.php b/src/DataConversion.php
@@ -489,6 +489,8 @@ public function fromRoundcube(array $save_data, ?VCard $vcard = null): VCard
             $vcard = new VObject\Component\VCard(['VERSION' => '3.0']);
         }
 
+        // set product
+        $vcard->PRODID = '-//MStilkerich//RCMCardDAV ' . carddav::PLUGIN_VERSION . '//EN';
         // update revision
         $vcard->REV = $this->dateTimeString();