Allow Context/ContextPdbData to impl Send. #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good but merging it would mean that I can't do a new release to crates.io until the pdb dependency is switched out for a regular crates.io dependency again. |
|
Yeah. I contacted Will Glynn but I've got no response. I'm hoping they're just on vacation or something. |
|
Just updated things to use the |
|
@mstange this ought to be ready for merge. |
|
Quite unfortunate that we had to do a pdb2, but we've waited long enough. Thanks for the patch and sorry for the huge delay! |
|
Agreed, but thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
wholesymstructures to beSend, which is necessary to use them across await points.