#49 ability to plot requirements curves #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionality of plotting requirements curves in calls to the
plot()method of theCorrelationFunctionSysTests and theScatterPlotSysTests, with some control of how those new curves look, and adds unit tests for this functionality. I made some interface choices here that could use a second pair of eyes: for example, you can plot requirement curves for b-mode and e-modes in the CorrFuncSysTests, but not the imaginary parts of any correlation function that has them; also that this is not included in the legend (which would be difficult for the scatter plots, but easy for the correlation function plots).Additionally, this PR fixes a bug relating to how versions of matplotlib report colors.
The unit tests more or less only tell you if the code runs, but if you want to see the plots, you can add
.savefig()commands in those unit tests to examine what they look like.Finally, I'll note that this PR should be merged (and possibly reviewed) after branch #98, since I needed to merge that functionality in here to get the unit tests to run at all!