change version code file

mshdabiola · Jun 13, 2024 · 4b347cd · 4b347cd
1 parent 5463b44
commit 4b347cd
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 5 deletions.
diff --git a/app/build.gradle.kts b/app/build.gradle.kts
@@ -20,8 +20,10 @@ android {
 
     defaultConfig {
         applicationId = "com.mshdabiola.playnotepad"
-        versionCode = 1
-        versionName = "0.0.1" // X.Y.Z; X = Major, Y = minor, Z = Patch level
+        versionCode = libs.versions.versionCode.get().toIntOrNull()
+        versionName = System.getenv("VERSION_NAME") ?: libs.versions.versionName.get()
+//        versionCode = 1
+//        versionName = "0.0.1" // X.Y.Z; X = Major, Y = minor, Z = Patch level
 
         // Custom test runner to set up Hilt dependency graph
         testInstrumentationRunner = "com.mshdabiola.testing.TestRunner"

diff --git a/build-logic/convention/src/main/kotlin/AndroidApplicationFirebaseConventionPlugin.kt b/build-logic/convention/src/main/kotlin/AndroidApplicationFirebaseConventionPlugin.kt
@@ -26,9 +26,9 @@ class AndroidApplicationFirebaseConventionPlugin : Plugin<Project> {
     override fun apply(target: Project) {
         with(target) {
             with(pluginManager) {
-//                apply("com.google.gms.google-services")
-//                apply("com.google.firebase.firebase-perf")
-//                apply("com.google.firebase.crashlytics")
+                apply("com.google.gms.google-services")
+                apply("com.google.firebase.firebase-perf")
+                apply("com.google.firebase.crashlytics")
             }
 
 //            dependencies {

diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -2,6 +2,9 @@
 agp = "8.4.1"
 androidTools = "31.3.2"
 
+versionName = "0.0.1"
+versionCode = "1"
+
 accompanist = "0.34.0"
 
 guava = "33.0.0-android"

diff --git a/instuctions b/instuctions
@@ -10,3 +10,7 @@
 
     ./gradlew :app:generateReleaseBaselineProfile
 
+            sed -i -e '/google-services/d' -e '/firebase/d' ../build.gradle.kts;
+            sed -i -e '/mlkit/,+14d' -e '/google-services/d' -e '/firebase/d' build.gradle.kts;
+            sed -i -e '/with(target) {/,/^        }/d' -e '/CrashlyticsExtension/d' build-logic/convention/src/main/kotlin/AndroidApplicationFirebaseConventionPlugin.kt
+