Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: make destroy() always destroy the socket #1125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

client: make destroy() always destroy the socket #1125

wants to merge 1 commit into from

Commits on Jan 28, 2022

  1. client: make destroy() always destroy the socket 

    If client.destroy() is called, always destroy the underlying socket so
that file descriptor is freed. This matches behavior of node's Socket and
Writable.

Previous behavior made this conditional on writability of the socket.
If the socket wasn't writable, then client.destroy() wouldn't actually
destroy the socket, the file descriptor would remain open, and the
node process would hang on exit.. It might timeout after 15 minutes, if
you're lucky.

fixes mscdex#1124
    @justfalter
    justfalter committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    24dcb3c View commit details
    Browse the repository at this point in the history