Skip to content

Commit

Permalink
Connection: default TLS servername to hostname
Browse files Browse the repository at this point in the history
Fixes: #724
Fixes: #866
  • Loading branch information
FLchs authored and mscdex committed Feb 17, 2022
1 parent 7dbc664 commit 9918f08
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lib/Connection.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ Connection.prototype.connect = function() {

if (config.tls) {
tlsOptions = {};
// servername must be set to prevent issues with some imap server and openssl 1.1.1
tlsOptions.servername = config.host;
tlsOptions.host = config.host;
// Host name may be overridden the tlsOptions
for (var k in config.tlsOptions)
Expand Down

4 comments on commit 9918f08

@samjonesigd
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be updated on NPM?

@zaghadon
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There have to create a new tag. 2 updates already and no new tag after 6 good years. Makes me wonder if any maintainer is still alive?

Could this be updated on NPM?

@zaghadon
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There have to create a new tag. 2 updates already and no new tag after 6 good years. Makes me wonder if any maintainer is still alive.

Could this be updated on NPM?

@samjonesigd
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There have to create a new tag. 2 updates already and no new tag after 6 good years. Makes me wonder if any maintainer is still alive.

Could this be updated on NPM?

Google's & Outlook's security doesn't allow it anymore anyway, for what I needed it for I've resorted to forwarding to my own mailserver that is less secure and using this to read from there.

Please sign in to comment.