delete interview scheduled meeting #232 #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
232-delete-interview-scheduled-meeting
senuravihanjayadeva
requested review from
senuravihanjayadeva,
ThusharaX,
rusiruavb,
uihalagedara and
KaveenLaksitha
senuravihanjayadeva
requested changes
Apr 30, 2022
| @@ -71,6 +71,8 @@ export const fetchMeetingById = async (meetingId: string) => { | |||
| export const deleteMeetingPermanently = (meetingId: string) => { | |||
| if (meetingId) { | |||
| return MeetingModel.findByIdAndDelete(meetingId) | |||
| return axios | |||
| .delete(`${process.env.MS_MEETING_MANAGER_API}/api/msteams/internalmeeting/meetingId`) | |||
There was a problem hiding this comment.
first, call this API then use findByIdAndDelete
| @@ -71,6 +71,8 @@ export const fetchMeetingById = async (meetingId: string) => { | |||
| export const deleteMeetingPermanently = (meetingId: string) => { | |||
| if (meetingId) { | |||
| return MeetingModel.findByIdAndDelete(meetingId) | |||
| return axios | |||
| .delete(`${process.env.MS_MEETING_MANAGER_API}/api/msteams/internalmeeting/meetingId`) | |||
There was a problem hiding this comment.
first we have to find if a internal meeting is existed for this speciific meetingId and then call axios.delete
| @@ -71,6 +71,8 @@ export const fetchMeetingById = async (meetingId: string) => { | |||
| export const deleteMeetingPermanently = (meetingId: string) => { | |||
| if (meetingId) { | |||
| return MeetingModel.findByIdAndDelete(meetingId) | |||
| return axios | |||
| .delete(`${process.env.MS_MEETING_MANAGER_API}/api/msteams/internalmeeting/meetingId`) | |||
There was a problem hiding this comment.
Here meetingId is hardcoded. this should be dynamic
senuravihanjayadeva
requested changes
Apr 30, 2022
|
All done |
senuravihanjayadeva
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
232-delete-interview-scheduled-meeting