build: upgrade very_good_analysis (#453)

* build: upgrade `very_good_analysis`

* build: use latest refs

bricks/altoke_app/brick/hooks/pubspec.yaml

@@ -12,11 +12,11 @@ dependencies:
     path: ../../../../tools/shell
 
 dev_dependencies:
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0
 
 dependency_overrides:
   shell:
     git:
       url: https://github.com/mrverdant13/altoke_bricks.git
-      ref: b071442ea80006c2b9de19c2f69fe36ee4b102ce
+      ref: 4231e8477f74b3ff53e4b21c13000dabb16392d5
       path: ./tools/shell/

bricks/altoke_app/reference/packages/app/lib/external/data/database_pod.dart

@@ -120,6 +120,7 @@ class SelectedLocalDatabasePackage extends _$SelectedLocalDatabasePackage {
     return LocalDatabasePackage.values.first;
   }
 
+  // No getter is needed as the state should be accessed directly.
   // ignore: avoid_setters_without_getters
   set value(LocalDatabasePackage value) => state = value;
 }

bricks/altoke_app/reference/packages/app/pubspec.yaml

@@ -81,7 +81,7 @@ dev_dependencies:
   #*w 1v 2> w*#
   riverpod_generator: ^2.6.2
   riverpod_lint: ^2.6.2
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0
 
 flutter:
   generate: true

bricks/altoke_app/reference/packages/app/test/helpers/mocks/counter.dart

@@ -6,6 +6,7 @@ class MockCounter extends CounterBase with Mock implements Counter {
     this.testBuild,
   ]);
 
+  // This is required for the mock only.
   // ignore: avoid_public_notifier_properties
   final int Function()? testBuild;
 

bricks/altoke_app/reference/packages/app/test/tasks/presentation/task_creation_dialog_test.dart

@@ -301,6 +301,7 @@ THEN the form should show the localized error
     variant: createTaskEmptyTitleErrorMessageL10nVariant,
   );
 
+  // Using a long semantic variable name.
   // ignore: lines_longer_than_80_chars
   final createTaskDescriptionRequiredForHighPriorityTaskErrorMessageL10nVariant =
       LocalizationVariant.withCommonSelector(

bricks/altoke_common/brick/hooks/pubspec.yaml

@@ -13,16 +13,16 @@ dependencies:
     path: ../../../../tools/value_equality_approach
 
 dev_dependencies:
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0
 
 dependency_overrides:
   shell:
     git:
       url: https://github.com/mrverdant13/altoke_bricks.git
-      ref: b071442ea80006c2b9de19c2f69fe36ee4b102ce
+      ref: 4231e8477f74b3ff53e4b21c13000dabb16392d5
       path: ./tools/shell/
   value_equality_approach:
     git:
       url: https://github.com/mrverdant13/altoke_bricks.git
-      ref: 1004669066d2eae47de8696387e3179f4b09061f
+      ref: 4231e8477f74b3ff53e4b21c13000dabb16392d5
       path: ./tools/value_equality_approach/

bricks/altoke_common/e2e/e2e/brick_e2e_test.dart

@@ -1,5 +1,5 @@
 @Tags(['e2e'])
-library brick_e2e_test;
+library;
 
 import 'dart:async';
 import 'dart:io';

bricks/altoke_common/e2e/lib/altoke_common_e2e.dart

@@ -1,2 +1,2 @@
 /// End-to-end tests for the Altoke Common brick.
-library altoke_common_e2e;
+library;

bricks/altoke_common/e2e/pubspec.yaml

@@ -17,4 +17,4 @@ dev_dependencies:
   test: ^1.25.8
   value_equality_approach:
     path: ../../../tools/value_equality_approach
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0

bricks/altoke_common/reference/lib/common.dart

@@ -1,4 +1,4 @@
 /// A set of common elements used across projects.
-library common;
+library;
 
 export 'src/types/types.dart';

bricks/altoke_common/reference/pubspec.yaml

@@ -36,4 +36,4 @@ dev_dependencies:
   #{{/use_freezed}}#
   #*w 1v 2> w*#
   test: ^1.25.8
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0

bricks/altoke_dart_package/brick/hooks/pubspec.yaml

@@ -11,11 +11,11 @@ dependencies:
     path: ../../../../tools/shell
 
 dev_dependencies:
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0
 
 dependency_overrides:
   shell:
     git:
       url: https://github.com/mrverdant13/altoke_bricks.git
-      ref: b071442ea80006c2b9de19c2f69fe36ee4b102ce
+      ref: 4231e8477f74b3ff53e4b21c13000dabb16392d5
       path: ./tools/shell/

bricks/altoke_dart_package/e2e/e2e/brick_e2e_test.dart

@@ -1,5 +1,5 @@
 @Tags(['e2e'])
-library brick_e2e_test;
+library;
 
 import 'dart:async';
 import 'dart:io';

bricks/altoke_dart_package/e2e/lib/altoke_dart_package_e2e.dart

@@ -1,2 +1,2 @@
 /// End-to-end tests for the Altoke Dart Package brick.
-library altoke_dart_package_e2e;
+library;

bricks/altoke_dart_package/e2e/pubspec.yaml

@@ -14,4 +14,4 @@ dev_dependencies:
   shell:
     path: ../../../tools/shell
   test: ^1.25.8
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0

bricks/altoke_dart_package/reference/lib/altoke_dart_package.dart

@@ -1,4 +1,4 @@
 /// An altoke Dart package.
-library altoke_dart_package;
+library;
 
 export 'src/altoke_dart_package.dart';

bricks/altoke_dart_package/reference/pubspec.yaml

@@ -13,4 +13,4 @@ dev_dependencies:
   #*w 1v 2> w*#
   #{{/use_code_generation}}#
   test: ^1.25.8
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0

bricks/altoke_entity/brick/hooks/pubspec.yaml

@@ -13,16 +13,16 @@ dependencies:
     path: ../../../../tools/value_equality_approach
 
 dev_dependencies:
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0
 
 dependency_overrides:
   shell:
     git:
       url: https://github.com/mrverdant13/altoke_bricks.git
-      ref: b071442ea80006c2b9de19c2f69fe36ee4b102ce
+      ref: 4231e8477f74b3ff53e4b21c13000dabb16392d5
       path: ./tools/shell/
   value_equality_approach:
     git:
       url: https://github.com/mrverdant13/altoke_bricks.git
-      ref: 1004669066d2eae47de8696387e3179f4b09061f
+      ref: 4231e8477f74b3ff53e4b21c13000dabb16392d5
       path: ./tools/value_equality_approach/

bricks/altoke_entity/e2e/e2e/brick_e2e_test.dart

@@ -1,5 +1,5 @@
 @Tags(['e2e'])
-library brick_e2e_test;
+library;
 
 import 'dart:async';
 import 'dart:io';

bricks/altoke_entity/e2e/lib/altoke_entity_e2e.dart

@@ -1,2 +1,2 @@
 /// End-to-end tests for the Altoke Entity brick.
-library altoke_entity_e2e;
+library;

bricks/altoke_entity/e2e/pubspec.yaml

@@ -16,4 +16,4 @@ dev_dependencies:
   test: ^1.25.8
   value_equality_approach:
     path: ../../../tools/value_equality_approach
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0

bricks/altoke_entity/reference/lib/altoke_entity.dart

@@ -1,5 +1,5 @@
 /// Representation of different altoke entity variants.
-library altoke_entity;
+library;
 
 /*replace-start*/
 export 'src/_cf___use_dart_mappable___altoke_entity.dart';

bricks/altoke_entity/reference/pubspec.yaml

@@ -43,4 +43,4 @@ dev_dependencies:
   #{{/use_freezed}}#
   #*w 1v 2> w*#
   test: ^1.25.8
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0

bricks/altoke_local_database/brick/hooks/pubspec.yaml

@@ -15,21 +15,21 @@ dependencies:
     path: ../../../../tools/shell
 
 dev_dependencies:
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0
 
 dependency_overrides:
   local_database_alternative:
     git:
       url: https://github.com/mrverdant13/altoke_bricks.git
-      ref: a7b80af2a0f003337b6d7a81dbbbf68bce7ba30f
+      ref: 4231e8477f74b3ff53e4b21c13000dabb16392d5
       path: ./tools/local_database_alternative/
   pubspec_deps_sorter:
     git:
       url: https://github.com/mrverdant13/altoke_bricks.git
-      ref: 0a1c19cb9a3e3b089993ab245c97ef13c6257a36
+      ref: 4231e8477f74b3ff53e4b21c13000dabb16392d5
       path: ./tools/pubspec_deps_sorter/
   shell:
     git:
       url: https://github.com/mrverdant13/altoke_bricks.git
-      ref: b071442ea80006c2b9de19c2f69fe36ee4b102ce
+      ref: 4231e8477f74b3ff53e4b21c13000dabb16392d5
       path: ./tools/shell/

bricks/altoke_local_database/e2e/e2e/brick_e2e_test.dart

@@ -1,5 +1,5 @@
 @Tags(['e2e'])
-library brick_e2e_test;
+library;
 
 import 'dart:async';
 import 'dart:io';

bricks/altoke_local_database/e2e/lib/altoke_local_database_e2e.dart

@@ -1,2 +1,2 @@
 /// End-to-end tests for the Altoke Local Database brick.
-library altoke_local_database_e2e;
+library;

bricks/altoke_local_database/e2e/pubspec.yaml

@@ -17,4 +17,4 @@ dev_dependencies:
   shell:
     path: ../../../tools/shell
   test: ^1.25.8
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0

bricks/altoke_local_database/reference/_cd___use_drift___drift_local_database/lib/drift_local_database.dart

@@ -1,5 +1,5 @@
 /// A persistent local database built on top of Drift (SQLite).
-library drift_local_database;
+library;
 
 export 'src/local_database.dart';
 export 'src/local_tasks_dao.dart';

bricks/altoke_local_database/reference/_cd___use_drift___drift_local_database/pubspec.yaml

@@ -26,4 +26,4 @@ dev_dependencies:
   build_runner: ^2.4.12
   drift_dev: ^2.21.2
   test: ^1.25.8
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0

bricks/altoke_local_database/reference/_cd___use_hive___hive_local_database/lib/hive_local_database.dart

@@ -1,4 +1,4 @@
 /// A persistent local database built on top of Hive.
-library hive_local_database;
+library;
 
 export 'src/local_tasks_dao.dart';

bricks/altoke_local_database/reference/_cd___use_hive___hive_local_database/pubspec.yaml

@@ -24,4 +24,4 @@ dependencies:
 
 dev_dependencies:
   test: ^1.25.8
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0

bricks/altoke_local_database/reference/_cd___use_isar___isar_local_database/lib/isar_local_database.dart

@@ -1,5 +1,5 @@
 /// A persistent local database built on top of Isar.
-library isar_local_database;
+library;
 
 export 'src/local_database_schemas.dart';
 export 'src/local_tasks_dao.dart';

bricks/altoke_local_database/reference/_cd___use_isar___isar_local_database/lib/src/helpers.dart

@@ -13,6 +13,7 @@ extension ExtendedUnfilteredQueryBuilderCondition<OBJ, R>
     on UnfilteredQueryBuilderCondition<OBJ, R> {
   /// A no-op query builder.
   FilteredQueryBuilderCondition<OBJ, R> noop() {
+    // Using a query builder that returns the same query without any changes.
     // ignore: invalid_use_of_protected_member
     return QueryBuilder.apply<OBJ, R, QAfterFilterCondition>(
       this,

bricks/altoke_local_database/reference/_cd___use_isar___isar_local_database/pubspec.yaml

@@ -30,4 +30,4 @@ dev_dependencies:
     hosted: https://pub.isar-community.dev/
     version: 3.1.8
   test: ^1.25.8
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0

bricks/altoke_local_database/reference/_cd___use_sembast___sembast_local_database/lib/sembast_local_database.dart

@@ -1,4 +1,4 @@
 /// A persistent local database built on top of Sembast.
-library sembast_local_database;
+library;
 
 export 'src/local_tasks_dao.dart';

bricks/altoke_local_database/reference/_cd___use_sembast___sembast_local_database/pubspec.yaml

@@ -24,4 +24,4 @@ dependencies:
 
 dev_dependencies:
   test: ^1.25.8
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0

bricks/altoke_local_database/reference/local_database/lib/local_database.dart

@@ -1,5 +1,5 @@
 /// An interface for a persistent local database.
-library local_database;
+library;
 
 export 'src/failures/failures.dart';
 export 'src/local_tasks_dao.dart';

bricks/altoke_local_database/reference/local_database/pubspec.yaml

@@ -20,4 +20,4 @@ dependencies:
 
 dev_dependencies:
   test: ^1.25.8
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0

bricks/altoke_local_database/reference/local_database/test/src/models/task_test.dart

@@ -41,6 +41,7 @@ void main() {
     });
 
     test('can be compared and has a consistent hash code', () {
+      // Using a non-const object to ensure coverage.
       // ignore: prefer_const_constructors
       final task = Task(
         id: 1,

bricks/altoke_reactive_caches/brick/hooks/pubspec.yaml

@@ -13,16 +13,16 @@ dependencies:
     path: ../../../../tools/shell
 
 dev_dependencies:
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0
 
 dependency_overrides:
   pubspec_deps_sorter:
     git:
       url: https://github.com/mrverdant13/altoke_bricks.git
-      ref: 63c80e3d14f2844bbef5d135b04338da6859a31f
+      ref: 4231e8477f74b3ff53e4b21c13000dabb16392d5
       path: ./tools/pubspec_deps_sorter/
   shell:
     git:
       url: https://github.com/mrverdant13/altoke_bricks.git
-      ref: b071442ea80006c2b9de19c2f69fe36ee4b102ce
+      ref: 4231e8477f74b3ff53e4b21c13000dabb16392d5
       path: ./tools/shell/

bricks/altoke_reactive_caches/e2e/e2e/brick_e2e_test.dart

@@ -1,5 +1,5 @@
 @Tags(['e2e'])
-library brick_e2e_test;
+library;
 
 import 'dart:async';
 import 'dart:io';

bricks/altoke_reactive_caches/e2e/lib/altoke_reactive_caches_e2e.dart

@@ -1,2 +1,2 @@
 /// End-to-end tests for the Altoke Reactive Caches brick.
-library altoke_reactive_caches_e2e;
+library;

bricks/altoke_reactive_caches/e2e/pubspec.yaml

@@ -13,4 +13,4 @@ dev_dependencies:
   shell:
     path: ../../../tools/shell
   test: ^1.25.8
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0

bricks/altoke_reactive_caches/reference/lib/reactive_caches.dart

@@ -1,5 +1,5 @@
 /// In-memory reactive caches.
-library reactive_caches;
+library;
 
 export 'src/reactive_element_cache.dart';
 export 'src/reactive_elements_list_cache.dart';

bricks/altoke_reactive_caches/reference/pubspec.yaml

@@ -20,5 +20,5 @@ dependencies:
 
 dev_dependencies:
   test: ^1.25.8
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0
 #*w 1v w*#

melos.yaml

@@ -39,7 +39,7 @@ command:
       meta: ^1.15.0
       mocktail: ^1.0.4
       test: ^1.25.8
-      very_good_analysis: ^6.0.0
+      very_good_analysis: ^7.0.0
   clean:
     hooks:
       pre:

tools/brick_generator/lib/src/reference_file.dart

@@ -80,7 +80,7 @@ extension ReferenceFile on File {
         return rename(resolvedPath);
       }();
       await resultingFile.resolveContents(brickGenData: brickGenData);
-    } catch (e) {
+    } on Object catch (e) {
       stderr.writeln(e);
     }
   }
@@ -91,7 +91,7 @@ extension ReferenceFile on File {
     try {
       await Git.ignores(this);
       return true;
-    } catch (e) {
+    } on Object {
       return false;
     }
   }

tools/brick_generator/pubspec.yaml

@@ -14,4 +14,4 @@ dependencies:
     path: ../shell
 
 dev_dependencies:
-  very_good_analysis: ^6.0.0
+  very_good_analysis: ^7.0.0