Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support rand_gamma on spark 3.4+ #165

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Conversation

zeotuan
Copy link
Collaborator

@zeotuan zeotuan commented Oct 6, 2024

  • Make rand_gamma work against spark 3.4+
  • Test native (unsafe) project against spark 3.4+
  • Test core daria project against spark 3.4+

@zeotuan zeotuan marked this pull request as ready for review October 6, 2024 10:57
This was referenced Oct 8, 2024
@alfonsorr
Copy link
Collaborator

LGTM but one thing, did you try to use the public method to allow the use of expressions? I mean not only use literals, like this:

.select(randGamma(col("shape"), col("scale")))

It only requires adding it to functions and makes it more open.

@zeotuan
Copy link
Collaborator Author

zeotuan commented Oct 11, 2024

LGTM but one thing, did you try to use the public method to allow the use of expressions? I mean not only use literals, like this:

.select(randGamma(col("shape"), col("scale")))

It only requires adding it to functions and makes it more open.

Good Idea. I have added version that support expression for shape and scale

Copy link
Collaborator

@alfonsorr alfonsorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks awsome!

@zeotuan zeotuan merged commit ffa6005 into mrpowers-io:main Oct 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants