-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sensor unit handling #81
Conversation
- cleanup handling of constants, fixes mrk-its#79 - set native_value instead of state, fixes mrk-its#80
d39a30e
to
60b3ea1
Compare
@mrk-its any chance I can get a review on this? This should resolve the issue of the integration showing the distance in KM no matter if you select KM or MI as your units. |
Sure, taking a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Is this ready to merge? |
@mrk-its sorry for the delay, had a few health issues. I made the change you requested, can I get a new review and possibly a merge? I'm running this version locally, and it starts up with no errors, and it should be fine, but there currently aren't any storms outside for me to validate the second commit. |
Hey @mrk-its wanted to bring this up again. I made the change that you requested, would be great to get this merged in to resolve the warnings in the logs about the upcoming deprecations. |
This also fixes #82 |
Thanks @cryptk and sorry it took so long |
Did some general cleanup around the handling of constants in order to resolve #79 while removing some of the custom constants that duplicated built-in constants.
Removed all instances that manually updated the entity state and replaced them with updates to native_value instead allowing Home Assistant to actually perform unit conversions resolving #80