feat(submodule): Submodule for Boxcraft #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odules Canvas fallback boxcraft submodules
Main backup
✅ Test Passed ✅Hi there @shrutivarade! It looks like the tests passed successfully. 😃 Please check the https://github.com/mpsych/boostlet/actions/runs/8789294768 for more details. If you want to access the screenshots taken for testing, you can do it through the developer's Claudinary management account, or through the workflow's artifacts. |
gaiborjosue
reviewed
Apr 22, 2024
package.json
Outdated
| "test": "node --experimental-modules ./tests/scripts/index.js" | ||
| "test": "node --experimental-modules ./tests/scripts/index.js", | ||
| "prebuild": "git submodule init && git submodule update", | ||
| "build-boxcraft": "npx parcel build submodule/BoxCraft/src/index.js --dist-dir ./dist && cp submodule/BoxCraft/dist/boxcraft.min.js ./dist/boxcraft.min.js && cp submodule/BoxCraft/dist/boxcraft.min.js.map ./dist/boxcraft.min.js.map", |
There was a problem hiding this comment.
Hello @shrutivarade, for the build command, specifically the build-boxcraft command, if a user runs it on a windows machine, the cp command does not exist.
Thus, the build files wouldn't be copied to the boostlet's dist folder.
|
Thanks @shrutivarade ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the issue for boxcraft screen ratio is fixed.
It uses canvas fallback for 2D canvases
It uses Boxcraft submodule to draw Bounding box