feat(CanvasFallback): Created 2d CanvasFallback #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(Canvas fallback): Added 2d canvas fallback functionality
✅ Test Passed ✅Hi there @gaiborjosue! It looks like the tests passed successfully. 😃 Please check the https://github.com/mpsych/boostlet/actions/runs/8115950652 for more details. If you want to access the screenshots taken for testing, you can do it through the developer's Claudinary management account, or through the workflow's artifacts. |
gaiborjosue
changed the title
haehn
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Super - look at all the removed code duplication!! Well done @gaiborjosue !
haehn
pushed a commit
that referenced
this pull request
Apr 23, 2024
…odules Canvas fallback boxcraft submodules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @haehn,
Major changes include:
This PR implements the 2d Canvas Fallback we discussed during this week's meeting. It also removes duplicated code from currently available frameworks.
Minor changes include:
Overall, this was my impression of the fallback, but please feel free to suggest improvements or guide the development; thanks!