Fix: Include allowedVendor param and update ModuleId value #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwangMP
approved these changes
Dec 16, 2024
alexs-mparticle
requested changes
Dec 18, 2024
| @@ -1264,7 +1264,13 @@ IdentityHandler.prototype.onLoginComplete = function( | |||
| var partnerData = this.common.buildPartnerData(mParticleUser); | |||
|
|
|||
| if (partnerData) { | |||
| var id5Instance = window.ID5.init({partnerId: this.common.partnerId, pd: partnerData}); | |||
| var id5Instance = window.ID5.init({ | |||
There was a problem hiding this comment.
Please don't check in the /dist folder in your PRs. These files are built when we release and any merge conflicts will prevent us from using automated releases.
| partnerId: this.common.partnerId, | ||
| pd: partnerData, | ||
| consentData: { | ||
| allowedVendors: [ '131', 'ID5-1747' ] |
There was a problem hiding this comment.
I see you're repeating some of these string values and there's a slight risk of some typos. I would make these values into constants so they can be reused and give us some safety.
This reverts commit 0e60701.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added new consent param to ID5 init per their recommendation and updated the ModuleId value as it looked to make ID5 kit initialization fail in my end to end test; this may be just impacting me but using a number ensure it matches how other kits are set-up.
Testing Plan
Tested via running NPM test builds
Master Issue
Closes https://go.mparticle.com/work/SQDSDKS-7015