Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rework commerce events #11

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

SbDove
Copy link
Collaborator

@SbDove SbDove commented Jul 9, 2024

Summary

Updates commerce event processing after additional testing in QA.

  • accounts for additional edge-case where a null value and key in a promotion would cause the secondary event to fail.
  • Re-adds the proper product action event names in the payload to Heap.

Testing Plan

{explain how this has been tested, and what additional testing should be done}
Tested in testEndToEnd and verified that events were populating in Heap properly.

Master Issue

Closes https://mparticle-eng.atlassian.net/browse/SQDPB-3981

@SbDove SbDove requested a review from alexs-mparticle July 9, 2024 23:17
@SbDove SbDove changed the title Rework commerce events feat: rework commerce events Jul 9, 2024
@SbDove SbDove marked this pull request as ready for review July 9, 2024 23:18
@SbDove SbDove changed the title feat: rework commerce events feat:rework commerce events Jul 9, 2024
@SbDove SbDove changed the title feat:rework commerce events feat: rework commerce events Jul 9, 2024
@SbDove SbDove merged commit 8fe71a0 into development Jul 10, 2024
3 of 4 checks passed
@SbDove SbDove deleted the feat/commerce-event-rework branch July 10, 2024 16:13
SbDove added a commit that referenced this pull request Jul 10, 2024
@alexs-mparticle alexs-mparticle restored the feat/commerce-event-rework branch July 10, 2024 17:39
alexs-mparticle pushed a commit that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants