Skip to content

Commit

Permalink
Update Branch SDK to 1.45.2 and mParticle SDK to 8.9 (#46)
Browse files Browse the repository at this point in the history
* SDK-1241 update mParticle to iOS SDK 1.45.0. Also increase min version to iOS 11 to keep in line with Xcode 14.

* SDK-1241 update to 1.45.1

* Added PR Template

* Update to iOS 1.45.2

---------

Co-authored-by: nsingh-branch <[email protected]>
  • Loading branch information
echo-branch and nsingh-branch authored Feb 1, 2023
1 parent d9ef679 commit 8a06508
Show file tree
Hide file tree
Showing 11 changed files with 49 additions and 13 deletions.
29 changes: 29 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
## Reference
SDK-XXXX -- <TITLE>.

## Summary
<!-- Simple summary of what was changed. -->

## Motivation
<!-- Why are you making this change? If it's for fixing a bug, if possible, please include a code snippet or example project that demonstrates the issue. -->

## Type Of Change
<!-- Please delete options that are not relevant -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update

## Testing Instructions
<!-- Testing instructions, example code snippets, etc -->


<!-- Checklist -->
<!-- My code follows the style guidelines of this project -->
<!-- I have performed a self-review of my code -->
<!-- I have commented my code, particularly in hard-to-understand areas -->
<!-- I have made corresponding changes to the documentation -->
<!-- I have added tests that prove my fix is effective or that my feature works -->
<!-- New and existing unit tests pass locally with my changes -->

cc @BranchMetrics/saas-sdk-devs for visibility.
4 changes: 2 additions & 2 deletions Cartfile
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
github "BranchMetrics/ios-branch-deep-linking" ~> 1.43
github "mparticle/mparticle-apple-sdk" ~> 8.8
github "BranchMetrics/ios-branch-deep-linking" ~> 1.45
github "mparticle/mparticle-apple-sdk" ~> 8.9
3 changes: 3 additions & 0 deletions Examples/Carthage/Branch Example.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@
developmentRegion = English;
hasScannedForEncodings = 0;
knownRegions = (
English,
en,
Base,
);
Expand Down Expand Up @@ -322,6 +323,7 @@
"$(PROJECT_DIR)/Carthage/Build/iOS",
);
INFOPLIST_FILE = "Branch Example/Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.mparticle.branchtesterapp;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand All @@ -338,6 +340,7 @@
"$(PROJECT_DIR)/Carthage/Build/iOS",
);
INFOPLIST_FILE = "Branch Example/Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.mparticle.branchtesterapp;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down
2 changes: 1 addition & 1 deletion Examples/Carthage/Cartfile
Original file line number Diff line number Diff line change
@@ -1 +1 @@
github "mparticle-integrations/mparticle-apple-integration-branchmetrics" ~> 7.0
github "mparticle-integrations/mparticle-apple-integration-branchmetrics" ~> 8.1
2 changes: 2 additions & 0 deletions Examples/Cocoapods/Branch Example.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,7 @@
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CODE_SIGN_ENTITLEMENTS = "Branch Example/Branch Example.entitlements";
INFOPLIST_FILE = "Branch Example/Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.mparticle.branchtesterapp;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand All @@ -382,6 +383,7 @@
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
CODE_SIGN_ENTITLEMENTS = "Branch Example/Branch Example.entitlements";
INFOPLIST_FILE = "Branch Example/Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.mparticle.branchtesterapp;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down
2 changes: 1 addition & 1 deletion Examples/Cocoapods/Podfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Uncomment this line to define a global platform for your project
# platform :ios, '9.0'
platform :ios, '11.0'

target 'Branch Example' do
use_frameworks!
Expand Down
2 changes: 1 addition & 1 deletion Examples/mParticle-Branch-Example/Podfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
platform :ios, '9.0'
platform :ios, '11.0'
use_frameworks!

target 'mParticle' do
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,7 @@
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_TEAM = R63EM248DP;
INFOPLIST_FILE = mParticle/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = io.branch.mParticleFortune;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand All @@ -447,6 +448,7 @@
CODE_SIGN_STYLE = Automatic;
DEVELOPMENT_TEAM = R63EM248DP;
INFOPLIST_FILE = mParticle/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = io.branch.mParticleFortune;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down
6 changes: 3 additions & 3 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import PackageDescription

let package = Package(
name: "mParticle-BranchMetrics",
platforms: [ .iOS(.v9) ],
platforms: [ .iOS(.v11) ],
products: [
.library(
name: "mParticle-BranchMetrics",
Expand All @@ -13,10 +13,10 @@ let package = Package(
dependencies: [
.package(name: "mParticle-Apple-SDK",
url: "https://github.com/mParticle/mparticle-apple-sdk",
.upToNextMajor(from: "8.2.0")),
.upToNextMajor(from: "8.9.0")),
.package(name: "Branch",
url: "https://github.com/BranchMetrics/ios-branch-sdk-spm",
.upToNextMajor(from: "1.39.4")),
.upToNextMajor(from: "1.45.2")),
],
targets: [
.target(
Expand Down
8 changes: 4 additions & 4 deletions mParticle-BranchMetrics.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "mParticle-BranchMetrics"
s.version = "8.0.6"
s.version = "8.1.0"
s.summary = "BranchMetrics integration for mParticle"

s.description = <<-DESC
Expand All @@ -13,8 +13,8 @@ Pod::Spec.new do |s|
s.source = { :git => "https://github.com/mparticle-integrations/mparticle-apple-integration-branchmetrics.git", :tag => s.version.to_s }
s.social_media_url = "https://twitter.com/mparticle"

s.ios.deployment_target = "9.0"
s.ios.deployment_target = "11.0"
s.ios.source_files = 'mParticle-BranchMetrics/*.{h,m,mm}'
s.ios.dependency 'mParticle-Apple-SDK/mParticle', '~> 8.8'
s.ios.dependency 'Branch', '~> 1.43'
s.ios.dependency 'mParticle-Apple-SDK/mParticle', '~> 8.9'
s.ios.dependency 'Branch', '~> 1.45'
end
2 changes: 1 addition & 1 deletion mParticle-BranchMetrics/MPKitBranchMetrics.m
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ @interface MPEvent (Branch)
- (MPMessageType) messageType;
@end

NSString *const MPKitBranchMetricsVersionNumber = @"8.0.6";
NSString *const MPKitBranchMetricsVersionNumber = @"8.1.0";
NSString *const ekBMAppKey = @"branchKey";
NSString *const ekBMAForwardScreenViews = @"forwardScreenViews";
NSString *const ekBMAEnableAppleSearchAds = @"enableAppleSearchAds";
Expand Down

0 comments on commit 8a06508

Please sign in to comment.