Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BrazeLocationProvider added to make automatic location collection works #82

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

ngrimaudo
Copy link

@ngrimaudo ngrimaudo commented Oct 12, 2023

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

What I did is reading the Braze Docs and I realized that the Automatic Location Collection was disabled because we were not providing a BrazeLocationProvider so it was set to null
![image](https://github.com/mparticle-integrations/mparticle-apple-integration-appboy/assets/33323953/9a9ce76b-2ef0-40b0
withoutBrazeProvider
-90c2-13c34a04df43)
So the location was not being collected on the Braze side

userwithoutBrazeProvider

Then I added the configuration that was needed:

        if (configuration.location.automaticLocationCollection) {
            configuration.location.brazeLocationProvider = [[BrazeLocationProvider alloc] init];
        }

And it started working correctly
withBrazeProvider
userwithBrazeProvider

Testing Plan

  • Was this tested locally? If not, explain why.
  • {explain how this has been tested, and what, if any, additional testing should be done}

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker force-pushed the development branch 2 times, most recently from aeaaca2 to 8eb56d3 Compare March 6, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant