fix: Add email_subscire and push_subscribe attribute fix #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrandonStalnaker
force-pushed
the
development
branch
7 times, most recently
from
5d49016 to
64d5e0a
Compare
einsteinx2
force-pushed
the
development
branch
3 times, most recently
from
4bd1e96 to
1c57900
Compare
BrandonStalnaker
force-pushed
the
development
branch
2 times, most recently
from
aeaaca2 to
8eb56d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A customer informed us that the email_subscribe and push_subscribe attribute assignment in Braze are not working per our docs stated. After further confirming and reproducing we also noticed that its the same case for the iOS integration as well and it was only working for the Web Braze kit.
Testing Plan
Tested by changing the code in kit locally and applying the functions and sent the user attributes email_subscribe and push_subscribe with the values "opted_in", "subscribed" and "unsubscribed" and worked as expected by confirming in the Braze UI. Also, added logging when the value inputed is not one of the three values mentioned above and the error gets logged as expected