New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Send ProductName to Braze (update flag) #175

Open

Mansi-mParticle wants to merge 2 commits into development from feat/SQDSDKS-6888-send-product-name2

Contributor

Mansi-mParticle commented Nov 13, 2024

Instructions

PR target branch should be against development
PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

Right now, in Android, we send product SKUs to Braze. The product name should also be sent for the native kits, just like we do for the Web kit. If a setting is enabled, the product name should be sent; otherwise, the SKU should be sent to Braze. Just update flag.

Testing Plan

Was this tested locally? If not, explain why.
Tested with the sample app and executed unit test cases

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Closes https://go.mparticle.com/work/SQDSDKS-6888

Mansi-mParticle and others added 2 commits

October 30, 2024 17:33


          fix: crossplatform testcase (#173)

c648bdb


          feat: Send ProductName to Braze (update flag)

cede303

einsteinx2 force-pushed the development branch from 220d165 to 787d332 Compare

December 12, 2024 15:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet