Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow spamd to call this hook when connection is closed #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

catap
Copy link
Contributor

@catap catap commented Dec 16, 2024

No description provided.

@mpaperno
Copy link
Owner

Thanks Kirill.

Could you give a little background on this? Does it solve some particular issue, or just "do as spampd does" type thing?

SpamAssassin::Plugin has this vague description:

$plugin->spamd_child_post_connection_close ()

    Called when child returns from handling a connection.

    If there was an accept failure, the child will die and this code will not be called.

"a connection" to what?

I found one mention of "spamd_child_post_connection_close" outside of the docs and spamd code, in some old Amavis release notes from 2008, mentioning adding it for compatibility with DBI plugin. But that plugin doesn't seem to exist (anymore).

So... just-in-case?

@catap
Copy link
Contributor Author

catap commented Dec 16, 2024

Yep, just in case.

I tried figured out why socket doesn't closed and discovers that I had missed that callback.

I think that it should be here, but defently not worth to be released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants