WIP: Added support for SpamAssassin client #43
Conversation
Ability to use SA client for auditing the message instead of embedded SA instance, this will decouple SpamAssassin and this proxy to be managed and run indepedently.
|
|
||
| # Check spamminess (returns Mail::SpamAssassin:PerMsgStatus object) | ||
| my $result = $assassin->check($mail); | ||
| # use Mail::SpamAssassin:PerMsgStatus object to rewrite message |
There was a problem hiding this comment.
It shouldn't bother rewriting the message at all unless it isspam or tagall flag is set.
There was a problem hiding this comment.
As assassin client will always rewrite the message. So in order to keep both implementation consistence this is done. I agree this operation is unwanted and ignored afterwards.
| my $status = $assassin->check($mail); | ||
|
|
||
| my $status = $self->audit(@msglines); | ||
| undef @msglines; |
There was a problem hiding this comment.
As now the @msglines are not passed as reference it's safe to set it undef here
There was a problem hiding this comment.
I didn't notice that before. My Perl is rusty but this means audit() is making a copy of the lines array (in my ($self, $msglines) = @_;), doesn't it? In fact it has to reconstruct the array from individual members (since what is actually passed is audit($msglines[0], $msglines[1], ...).
| $sa_c = Mail::SpamAssassin::Client->new($sa_c); | ||
| $self->{assassinc} = $sa_c; | ||
| $self->inf("Pinging sa daemon"); | ||
| if ($sa_c->ping()){ |
There was a problem hiding this comment.
What happens if it doesn't respond? Is the whole startup useless (or will fail?) or will it connect to spamd later?
There was a problem hiding this comment.
as per https://github.com/apache/spamassassin/blob/e088d9e28c5342cb9b31daa2b0516425eaaa1d68/lib/Mail/SpamAssassin/Client.pm#L590 client create new connection for each request.
There was a problem hiding this comment.
Won't it slow down the start if spamd doean't run yet? If I not mistaken default timeout somting like 30 seconds.
- rename isspam ->is_spam - call finish() $assassin response
Ability to use SA client for auditing the message instead of embedded SA instance, this will decouple SpamAssassin and this proxy to be managed and run indepedently.
#42