Merge pull request #12 from jhonatasrm/security-fixes

Security fixes Updated README.md Updated loading appearence Updated Strings
mozillabrasil · Jul 21, 2019 · 06137d3 · 06137d3
2 parents 957477e + e430200
commit 06137d3
Show file tree

Hide file tree

Showing 4 changed files with 42 additions and 17 deletions.
diff --git a/README.md b/README.md
@@ -37,6 +37,8 @@ We are looking forward to see what you think is a good idea implement in the fut
 ## How Contribute
 Have a suggestion, doubt or encountered an error? Please open a new [issue](https://github.com/mozillabrasil/sumo_live_helper/issues).
 
+Contributions are welcome, feel free to submit a pull :)
+
 ## Learn More
 To learn more about webextensions development, see this [Mozilla developer Network documentation](https://developer.mozilla.org/en-US/Add-ons/WebExtensions).
 

diff --git a/src/css/popup.css b/src/css/popup.css
@@ -90,8 +90,8 @@ a.active {
 .question-settings {
     margin-left:20px;
     margin-top:5px;
-    max-width:230px;
-    min-width:230px;
+    max-width:255px;
+    min-width:255px;
     font-size:13px;
 }
 
@@ -102,8 +102,8 @@ a.active {
 }
 
 .distances-loading {
-    margin-left:230px;
-    margin-top:30px;
+    margin-left:222px;
+    margin-top:50px;
     margin-bottom:50px;
 }
 
@@ -112,6 +112,6 @@ a.active {
     color:white;
     cursor:pointer;
     font-color:white;
-    width:80px;
+    width:90px;
     font-size:13px;
 }
diff --git a/src/html/popup.html b/src/html/popup.html
@@ -20,9 +20,9 @@
         <!-- Questions -->
         <div class="col-md-12" style="display: none;" id="questions">
             <!-- Questions opened -->
-                <div class="col-md-12 margin-and-top-distance">
-                    <img src="../res/icons/firefox.png" class="icon-size-and-distance" title="Firefox for Desktop"><label class="text-justify question-settings"></label><a class="btn btn-primary btn-settings" data-i18n="open_tab" id="open_tab"></a>
-                </div></br>
+            <section>
+
+            </section>
         </div>
         <!-- No questions -->
         <div class="col-md-12 margin-and-top-distance" id="empty" style="display: none;">

diff --git a/src/js/background.js b/src/js/background.js
@@ -59,15 +59,38 @@ request.onload = function() {
                             // url of the question
                             var url = "https://support.mozilla.org/"+locale+"/questions/"+responseSUMO.results[i].id;
 
-                            questionOpened += '<div class="col-md-12 margin-and-top-distance">';
-                            questionOpened += '<img src="../res/icons/firefox.png" class="icon-size-and-distance" title="Firefox for Desktop">';
-                            questionOpened += '<label class="text-justify question-settings">'+responseSUMO.results[i].title+'</label>';
-                            questionOpened += '<a href='+url+' class="btn btn-primary btn-settings" data-i18n="open_tab" id="open_tab" style="color:white;">'+browser.i18n.getMessage("open_tab");
-                            questionOpened += '</a>';
-                            questionOpened += '</div></br>';
-                            questionOpened += '<div class="panel-section-separator"></div>';
-
-                            questions.innerHTML = questionOpened;
+                            // create elements
+                            var questionOrder = document.createElement("div");
+                            var questionTitle = document.createElement("label");
+                            var iconProduct = document.createElement("img");
+                            var zeroDiv = document.createElement("div");
+                            var firstDiv = document.createElement("div");
+                            var secondDiv = document.createElement("div");
+                            var buttonOpen = document.createElement("a");
+                            var section = document.querySelector("section");
+
+                            //
+                            zeroDiv.className = "col-md-12 margin-and-top-distance";
+                            firstDiv.className = "col-md-12 margin-and-top-distance";
+                            secondDiv.className = "panel-section-separator"
+                            questionTitle.className = "text-justify question-settings";
+                            questionTitle.textContent = responseSUMO.results[i].title;
+                            iconProduct.className = "icon-size-and-distance";
+                            iconProduct.title = browser.i18n.getMessage("firefox_for_desktop");
+                            iconProduct.src = "../res/icons/firefox.png";
+                            buttonOpen.className = "btn btn-primary btn-settings";
+                            buttonOpen.text = browser.i18n.getMessage("open_tab");
+                            buttonOpen.href = url;
+
+                            //
+                            questionOrder.appendChild(zeroDiv);
+                            questionOrder.appendChild(iconProduct);
+                            questionOrder.appendChild(questionTitle);
+                            questionOrder.appendChild(buttonOpen);
+                            questionOrder.appendChild(firstDiv);
+                            questionOrder.appendChild(secondDiv);
+
+                            section.appendChild(questionOrder);
                         }
                     }
                 }