Handle new "tab closed" response from Chrome #385

fregante · 2022-06-05T05:31:53Z

Presumably fixes A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received #384

fregante · 2022-06-06T16:01:37Z

CI is failing for unrelated reasons

Rob--W

Could you add a unit test?

webextension-polyfill/test/test-runtime-onMessage.js

Lines 242 to 265 in 2ece178

    
           it("resolves to undefined when no listeners reply", () => { 
        
             const fakeChrome = { 
        
               runtime: { 
        
                 // This error message is defined as CHROME_SEND_MESSAGE_CALLBACK_NO_RESPONSE_MESSAGE 
        
                 // in the polyfill sources and it is used to recognize when Chrome has detected that 
        
                 // none of the listeners replied. 
        
                 lastError: { 
        
                   message: "The message port closed before a response was received.", 
        
                 }, 
        
                 sendMessage: sinon.stub(), 
        
               }, 
        
             }; 
        
             fakeChrome.runtime.sendMessage.onFirstCall().callsArgWith(1, [undefined]); 
        
             return setupTestDOMWindow(fakeChrome).then(window => { 
        
               const promise = window.browser.runtime.sendMessage("some_message"); 
        
               ok(fakeChrome.runtime.sendMessage.calledOnce, "sendMessage has been called once"); 
        
               return promise.then(reply => { 
        
                 deepEqual(reply, undefined, "sendMessage promise should be resolved to undefined"); 
        
               }); 
        
             }); 
        
           });

If you'd like, it would also be nice to add an integration test that triggers the error in a real Chrome browser (in case the error message changes), at https://github.com/mozilla/webextension-polyfill/tree/master/test/fixtures

from the webextension-polyfill (and removes the minified file). The patch silences the following warning that started to appear in recent Chrome versions: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received refs ghostery#808

from the webextension-polyfill (and removes the minified file). The patch silences the following warning that started to appear in recent Chrome versions: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received refs ghostery#806

* Apply patch mozilla/webextension-polyfill#385 from the webextension-polyfill (and removes the minified file). The patch silences the following warning that started to appear in recent Chrome versions: A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received refs #806 * Added CHANGELOG

fregante · 2023-01-13T06:37:06Z

Sorry I haven't had time to finish this.

Handle new "tab closed" response from Chrome

2115de0

This was referenced Jun 5, 2022

A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received #384

Open

Listener indicated async response by returning true, but channel was closed pixiebrix/pixiebrix-extension#3560

Closed

Rob--W requested changes Jun 9, 2022

View reviewed changes

philipp-classen mentioned this pull request Jul 28, 2022

Fix resolving the promise if there is no scripts to inject ghostery/adblocker#2724

Closed

This was referenced Aug 11, 2022

Apply patch for webextension-polyfill to silence Chrome warning ghostery/ghostery-extension#830

Merged

Error in console: Uncaught (in promise) ghostery/ghostery-extension#806

Closed

fregante closed this Jan 13, 2023

fregante deleted the patch-3 branch January 13, 2023 06:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle new "tab closed" response from Chrome #385

Handle new "tab closed" response from Chrome #385

fregante commented Jun 5, 2022

fregante commented Jun 6, 2022

Rob--W left a comment

fregante commented Jan 13, 2023

	it("resolves to undefined when no listeners reply", () => {
	const fakeChrome = {
	runtime: {
	// This error message is defined as CHROME_SEND_MESSAGE_CALLBACK_NO_RESPONSE_MESSAGE
	// in the polyfill sources and it is used to recognize when Chrome has detected that
	// none of the listeners replied.
	lastError: {
	message: "The message port closed before a response was received.",
	},
	sendMessage: sinon.stub(),
	},
	};

	fakeChrome.runtime.sendMessage.onFirstCall().callsArgWith(1, [undefined]);

	return setupTestDOMWindow(fakeChrome).then(window => {
	const promise = window.browser.runtime.sendMessage("some_message");
	ok(fakeChrome.runtime.sendMessage.calledOnce, "sendMessage has been called once");

	return promise.then(reply => {
	deepEqual(reply, undefined, "sendMessage promise should be resolved to undefined");
	});
	});
	});

Handle new "tab closed" response from Chrome #385

Handle new "tab closed" response from Chrome #385

Conversation

fregante commented Jun 5, 2022

fregante commented Jun 6, 2022

Rob--W left a comment

Choose a reason for hiding this comment

fregante commented Jan 13, 2023