Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply patch for webextension-polyfill to silence Chrome warning #830

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

philipp-classen
Copy link
Member

Apply patch mozilla/webextension-polyfill#385 from the webextension-polyfill (and removes the minified file). The patch silences the following warning that started to appear in recent Chrome versions:

A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received

refs #806

from the webextension-polyfill (and removes the minified file). The patch
silences the following warning that started to appear in recent Chrome versions:

A listener indicated an asynchronous response by returning true, but the message channel closed before a response was received

refs ghostery#806
Copy link
Member

@chrmod chrmod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a note about it in changelog

@philipp-classen philipp-classen force-pushed the patch_webextension_polyfill branch from 4ad3904 to 0982b31 Compare August 12, 2022 10:28
@chrmod chrmod merged commit 9f9d1c4 into ghostery:main Aug 12, 2022
@philipp-classen philipp-classen deleted the patch_webextension_polyfill branch August 25, 2022 10:57
philipp-classen added a commit to philipp-classen/common that referenced this pull request Oct 7, 2022
philipp-classen added a commit to ghostery/common that referenced this pull request Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants