Skip to content

Commit

Permalink
Upgrade Taskgraph and cleanup firefox-translations-training (#341)
Browse files Browse the repository at this point in the history
* Delete in-tree docker_image and fetch transforms

* Set default task-expires-after to 90 days

* Use default task-expires-after to set expires-after

* Use Taskgraph 7.1.0
  • Loading branch information
gabrielBusta authored Jan 8, 2024
1 parent 5214364 commit 03a5ff8
Show file tree
Hide file tree
Showing 39 changed files with 263 additions and 818 deletions.
1 change: 1 addition & 0 deletions taskcluster/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
trust-domain: "translations"
task-priority: low
task-deadline-after: 60 days
task-expires-after: 90 days
treeherder:
group-names:
"I": "Docker images"
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/all-pr/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ tasks:
- attributes

run-on-tasks-for: ["github-pull-request"]
expires-after: "90 days"
worker-type: succeed

from-deps:
Expand Down
2 changes: 0 additions & 2 deletions taskcluster/kinds/bicleaner/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ task-defaults:
substitution-fields:
- run.command

expires-after: "90 days"

worker:
max-run-time: 86400
env:
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/cefilter/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ tasks:
- fetches
- attributes
worker-type: b-cpu-largedisk
expires-after: "90 days"
worker:
docker-image: {"in-tree": "train"}
max-run-time: 86400
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/clean-corpus/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ tasks:
- fetches
- worker.env
- run.command
expires-after: "90 days"
worker:
docker-image: {"in-tree": "train"}
max-run-time: 86400
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/clean-mono/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ task-defaults:
- dependencies
- fetches
- run.command
expires-after: "90 days"
worker:
docker-image: {"in-tree": "train"}
max-run-time: 86400
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/collect-corpus/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ tasks:
- artifact: corpus.{trg_locale}.zst

worker-type: b-cpu-largedisk
expires-after: "90 days"
worker:
docker-image: {"in-tree": "train"}
max-run-time: 86400
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/collect-mono-src/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ task-defaults:
- fetches
- attributes
worker-type: b-cpu-largedisk
expires-after: "90 days"
worker:
docker-image: {"in-tree": "train"}
max-run-time: 86400
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/collect-mono-trg/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ task-defaults:
- fetches
- attributes
worker-type: b-cpu-largedisk
expires-after: "90 days"
worker:
docker-image: {"in-tree": "train"}
max-run-time: 86400
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/dataset/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ task-defaults:
- run.command
task-context:
substitution-fields: []
expires-after: "90 days"
worker:
docker-image: {in-tree: toolchain-build}
max-run-time: 86400
Expand Down
2 changes: 1 addition & 1 deletion taskcluster/kinds/docker-image/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
loader: taskgraph.loader.transform:loader

transforms:
- translations_taskgraph.transforms.docker_image:transforms
- taskgraph.transforms.docker_image:transforms
- taskgraph.transforms.cached_tasks:transforms
- taskgraph.transforms.task:transforms

Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/evaluate-quantized/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ task-defaults:
pipeline_setup: >-
worker-type: b-gpu
expires-after: "90 days"
worker:
artifacts:
- name: public/build
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/evaluate-teacher-ensemble/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ task-defaults:
src_locale: training_config.experiment.src
trg_locale: training_config.experiment.trg
worker-type: b-gpu
expires-after: "90 days"
worker:
artifacts:
- name: public/build
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/evaluate/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ task-defaults:
trg_locale: training_config.experiment.trg
split_chunks: training_config.experiment.teacher-ensemble
worker-type: b-gpu
expires-after: "90 days"
worker:
artifacts:
- name: public/build
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/export/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ tasks:
- dependencies
- worker.env
- attributes
expires-after: "90 days"
worker-type: b-cpu
worker:
docker-image: {"in-tree": "train"}
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/extract-best/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ tasks:
- run.command

worker-type: b-cpu-largedisk
expires-after: "90 days"
worker:
docker-image: {"in-tree": "train"}
max-run-time: 86400
Expand Down
3 changes: 1 addition & 2 deletions taskcluster/kinds/fetch/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,12 @@
loader: taskgraph.loader.transform:loader

transforms:
- translations_taskgraph.transforms.fetch:transforms
- taskgraph.transforms.fetch:transforms
- taskgraph.transforms.run:transforms
- taskgraph.transforms.task:transforms

task-defaults:
docker-image: {in-tree: base}
expires-after: "90 days"

tasks-from:
- bicleaner.yml
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/finetune-student/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ tasks:
run-on-tasks-for: []

worker-type: b-largegpu-xlargedisk
expires-after: "90 days"
worker:
max-run-time: 2592000
env:
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/merge-corpus/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ task-defaults:
- "{dataset_sanitized}.{src_locale}.zst"
- "{dataset_sanitized}.{trg_locale}.zst"
worker-type: b-cpu-largedisk
expires-after: "90 days"
worker:
docker-image: {"in-tree": "train"}
max-run-time: 86400
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/merge-devset/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ task-defaults:
- "{dataset_sanitized}.{src_locale}.zst"
- "{dataset_sanitized}.{trg_locale}.zst"
worker-type: b-cpu
expires-after: "90 days"
worker:
docker-image: {"in-tree": "train"}
max-run-time: 86400
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/merge-mono/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ task-defaults:
- "{dataset_sanitized}.{locale}.zst"

worker-type: b-cpu-largedisk
expires-after: "90 days"
worker:
docker-image: { "in-tree": "train" }
max-run-time: 86400
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/merge-translated/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ task-defaults:
- run.command
- attributes
worker-type: b-cpu-largedisk
expires-after: "90 days"
worker:
docker-image: {"in-tree": "train"}
max-run-time: 86400
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/quantize/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ tasks:
- run.command
- attributes
worker-type: b-cpu
expires-after: "90 days"
worker:
docker-image: {"in-tree": "train"}
max-run-time: 86400
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/score/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ tasks:
- run.command

worker-type: b-largegpu
expires-after: "90 days"
worker:
max-run-time: 2592000
env:
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/split-corpus/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ tasks:
- attributes
- run.command
worker-type: b-cpu-largedisk
expires-after: "90 days"
worker:
docker-image: {"in-tree": "train"}
max-run-time: 86400
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/split-mono-src/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ task-defaults:
- run.command

worker-type: b-cpu-largedisk
expires-after: "90 days"
worker:
docker-image: { "in-tree": "train" }
max-run-time: 86400
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/split-mono-trg/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ task-defaults:
- run.command

worker-type: b-cpu-largedisk
expires-after: "90 days"
worker:
docker-image: { "in-tree": "train" }
max-run-time: 86400
Expand Down
6 changes: 0 additions & 6 deletions taskcluster/kinds/tests/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ tasks:
snakemake-dry-run:
# Ensure that the snakemake workflow is still executing correctly, even though
# taskcluster is the preferred execution environment.
expires-after: "90 days"
worker-type: b-cpu
worker:
max-run-time: 3600
Expand Down Expand Up @@ -58,7 +57,6 @@ tasks:
black:
# Run python's black formatter, which formats python files.
expires-after: "90 days"
worker-type: b-cpu
worker:
max-run-time: 3600
Expand All @@ -74,7 +72,6 @@ tasks:

lint:
# Run ruff, a python linter.
expires-after: "90 days"
worker-type: b-cpu
worker:
max-run-time: 3600
Expand All @@ -90,7 +87,6 @@ tasks:

test:
# Run unit tests
expires-after: "90 days"
worker-type: b-cpu
worker:
max-run-time: 3600
Expand All @@ -111,7 +107,6 @@ tasks:
- Makefile

taskgraph-definition:
expires-after: "90 days"
worker-type: b-cpu
worker:
docker-image: {in-tree: base}
Expand All @@ -127,7 +122,6 @@ tasks:
make validate-taskgraph
taskgraph-diff:
expires-after: "90 days"
worker-type: b-cpu
worker:
docker-image: {in-tree: base}
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/toolchain/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ transforms:

task-defaults:
worker-type: b-cpu
expires-after: "90 days"
worker:
docker-image: {"in-tree": "toolchain-build"}
max-run-time: 3600
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/train-backwards/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ tasks:
- attributes
- run.command
worker-type: b-largegpu-largedisk
expires-after: "90 days"
worker:
max-run-time: 2592000
env:
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/train-student/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ tasks:
from-parameters:
marian_args: training_config.marian-args.training-student
worker-type: b-largegpu-xlargedisk
expires-after: "90 days"
worker:
max-run-time: 2592000
env:
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/train-teacher/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ tasks:
teacher-ensemble: training_config.experiment.teacher-ensemble
pretrained_teacher: training_config.experiment.pretrained-models.train-teacher
worker-type: b-largegpu-xlargedisk
expires-after: "90 days"
worker:
max-run-time: 2592000
env:
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/train-vocab/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ tasks:
- attributes
- run.command
worker-type: b-cpu
expires-after: "90 days"
worker:
docker-image: {"in-tree": "train"}
max-run-time: 86400
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/translate-corpus/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ tasks:
run-on-tasks-for: []

worker-type: b-largegpu-xlargedisk
expires-after: "90 days"
worker:
max-run-time: 2592000
artifacts:
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/translate-mono-src/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ task-defaults:
- attributes

worker-type: b-largegpu
expires-after: "90 days"
worker:
max-run-time: 2592000
artifacts:
Expand Down
1 change: 0 additions & 1 deletion taskcluster/kinds/translate-mono-trg/kind.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ task-defaults:
from-parameters: training_config.marian-args.decoding-backward

worker-type: b-largegpu
expires-after: "90 days"
worker:
max-run-time: 2592000
artifacts:
Expand Down
Loading

0 comments on commit 03a5ff8

Please sign in to comment.