-
Notifications
You must be signed in to change notification settings - Fork 398
Please don't die: collection of typos #2442
base: master
Are you sure you want to change the base?
Conversation
I think it's a good initiative yes, and for sure dozen of developers will join if there is |
I've already ported it to latest TS with no-implicit-any settings in a different branch. |
8f76abb
to
2b9645e
Compare
Keep up the good efforts, just letting you know i also keep an eye on this 😉 |
@TriMoon here's branch typescript 2.6, just conversion that somehow breaks 1 test: https://github.com/ivanpopelyshev/shumway/tree/ts2 I have more branches but they're for heavy refactoring. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@ivanpopelyshev Thank you for your continued effort in this project! Since I am personally interested in the future of it as well, I hope for it to attract many developers. In my opinion, one necessary condition for this are good commit messages, which are consistent (e.g. I quite like Angular's @mbebenita @yurydelendik (I hope you are the maintainers, judging from your contributions): Are there any plans to (continuously) accept PRs or would it be better - in your opinion - to move all the work onto a fork (i.e. @ivanpopelyshev's fork)? |
I’m building a WebExtension in my own fork (see issue #2435 for details), but it’s unfortunately somewhat blocked by bugs that block bug 1451083. |
https://github.com/pixijs/pixi-swf And I'm cooperating with @yurydelendik Wow, that's good! |
Hey dude, I'm a big fan of flash and have been bummed out over these big companies deciding that everybody should just drop flash in 2020. But you give me hope for flash to remain on the web! What's important is not the flash plugin itself after all, it's the flash format. Will Pixi-SWF be able to play unmodified .swf files as they are? A WebExtension version of the flash plugin also sounds awesome, is it correct to assume that the plan is to be able to playback unmodified .swf files with it? |
@WeanedVitriolic Thank you! I removed AVM for now, it'll be and option later (for debug purposes). That means it cant use the ABC blocks from SWF, and you need to port your AS3 code to typescript, Shumway Flash API is almost the same. All SWF files should be loaded dynamically through good old The project goal is to help to migrate projects to TypeScript, without extra difficulties like There's also commercial part that helps to convert HUGE applications. |
The goal is to provide a fully compatible replacement for the legacy Shumway extension, which installs itself as a plugin that can play unmodified Flash files (currently only Since I can’t currently do that (unless bug 1451983 (duplicate of bug 1356397) gets implemented), I need to create an Since I’m using Shadow DOM, I might possibly end up using the Custom Elements |
Actually, I wished for a drop-in JS tool for Flash to run SWFs (and eventually Java applets as well) seamlessly on the many sites which either provide valuable information/simulations not easily found somewhere else (usually with academic background) or have some nostalgic games. It might well be the case that your user audience is different, namely customers wishing to port their old SWFs with minimum effort. |
Ok, got it.
If you dont want to rewrite code to Javascript/Typescript, 1st option is still available. But I certainly would not work on optimizing virtual machine, only the renderer and stage. |
I think it's better for you all to invest your time, brain and imagination to webassembly git which |
The longer is the toolchain, the more problems it introduces. Its not clear to me how is it supposed to solve fundamental problems of flash runtimes. Our main problem is a runtime and API's, not the language nor VM. |
|
Sounds like Pixi-SWF won't be able to play unmodified .swf files as they are, thanks for clearing it up and good luck with your convert tool! Your WebExtension project does on the other hand sound like it will be able to play unmodified .swf as they are. Looking forward to it! As long as people will be able to play old .swf files in their browser somehow I'm happy. There's 100s of thousands of .swf files and I don't think anybody will put the energy into converting them all so I really want there to be a way to play the original unmodified flashes in the browser. No classic animation or game should be lost, they all helped make the web what it is today and deserve to stay online forever. Doesn't matter if it's through WebExtension, JavaScript or WebAssembly as long as it works without conversion. :) |
I saw that https://bugzilla.mozilla.org/show_bug.cgi?id=1356397 was updated a day ago:
Since there was both a deny and an accept in there would you mind clarifying what this means for your WebExtension? Does this mean you're able to continue the project or was it bad news? |
Based on my understanding, Mozilla intends to implement a better API than what would essentially just be an alias for |
So good news then? :) |
@WeanedVitriolic Yes: (In reply to Rob Wu [:robwu] from bug 1457500 comment #3)
|
Awesome! I'll keep an eye on your project over at https://github.com/ExE-Boss/mozilla-shumway/tree/web-extension/extension/webext I hope you'll be able to pull it off! |
I know that project is not maintained, I'd like to adopt it.