Fixed menu component focusout bug (Fixes #247)

mozilla · Oct 22, 2018 · dcddfcd · dcddfcd
1 parent bb0b9f9
commit dcddfcd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,10 @@
 
 * **docs:** Document deployment process (#171)
 
+## Bug Fixes
+
+* **js:** Fixed menu component focusout bug (#247)
+
 # 2.4.2
 
 * **css:** Add blockquote component (#234)

diff --git a/src/assets/js/protocol/protocol-menu.js b/src/assets/js/protocol/protocol-menu.js
@@ -155,7 +155,8 @@ if (typeof Mozilla === 'undefined') {
          * re-queues the JavaScript to run at the end of the current excecution.
          */
         setTimeout(function() {
-            if (!self.contains(document.activeElement)) {
+            // If the menu is open and the newly focused element is not a child, then call close().
+            if (!self.contains(document.activeElement) && self.classList.contains('is-selected')) {
                 Menu.close();
             }
         }, 0);