ci(clippy): include benchmarks #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2372 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 114 114
Lines 36856 36856
Branches 36856 36856
=======================================
Hits 35123 35123
Misses 1727 1727
Partials 6 6 ☔ View full report in Codecov by Sentry. |
|
Note that we can do the change below once async closures are stable: diff --git a/neqo-bin/benches/main.rs b/neqo-bin/benches/main.rs
index b2ef0987..43220b61 100644
--- a/neqo-bin/benches/main.rs
+++ b/neqo-bin/benches/main.rs
@@ -57,7 +57,7 @@ fn transfer(c: &mut Criterion) {
group.bench_function("client", |b| {
b.to_async(Runtime::new().unwrap()).iter_batched(
|| client::client(client::Args::new(&requests, upload)),
- |client| async move {
+ async |client| {
client.await.unwrap();
},
BatchSize::PerIteration, |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to df0a4dd. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
larseggert
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.