- Address PR comments

Signed-off-by: William Johnson <[email protected]>
mozilla · May 24, 2023 · b28fe78 · b28fe78
1 parent 10bb05a
commit b28fe78
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/jexl-eval/src/lib.rs b/jexl-eval/src/lib.rs
@@ -803,7 +803,7 @@ mod tests {
             value!([{"bobo": 50, "fofo": 100}, {"bobo": 60, "baz": 90}])
         );
     }
-    
+
     #[test]
     fn test_binary_op_eq_ne() {
         let evaluator = Evaluator::new();
@@ -835,8 +835,7 @@ mod tests {
         test("BOOLEAN", "true", true);
         test("OBJECT", "OBJECT", true);
         test("ARRAY", "[ 'string' ]", true);
-        test("NULL",  "Null", true);
-        test("NULL",  "null", true);
+        test("NULL", "null", true);
 
         test("OBJECT", "{ 'x': 1, 'y': 2 }", false);
 

diff --git a/jexl-parser/src/lib.rs b/jexl-parser/src/lib.rs
@@ -138,7 +138,7 @@ mod tests {
 
     #[test]
     fn test_dot_op_equality_with_null() {
-        let exp = "foo.bar == Null";
+        let exp = "foo.bar == null";
         let parsed = Parser::parse(exp).unwrap();
         assert_eq!(
             parsed,

diff --git a/jexl-parser/src/parser.lalrpop b/jexl-parser/src/parser.lalrpop
@@ -128,9 +128,7 @@ String: String = {
 };
 
 Null: Option<Box<Expression>> = {
-    "Null" => None,
     "null" => None,
-    "NULL" => None,
 }
 
 Identifier: String = {