Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Fix ios log path for artifact fetching on CI. #11973

Merged
merged 1 commit into from
Dec 19, 2024
Merged

chore(ci): Fix ios log path for artifact fetching on CI. #11973

merged 1 commit into from
Dec 19, 2024
+1 −1

Conversation

b4handjr
Copy link
Contributor

@b4handjr b4handjr commented Dec 19, 2024 •
edited
Loading

Because

  • The log path changed recently on our iOS CI job (maybe due to new macos images on circleci).

This commit

  • Changes the path to be a bit more generic.

Fixes #11973

@b4handjr b4handjr enabled auto-merge December 19, 2024 15:55
jaredlockhart
jaredlockhart approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch, also missing the github bug number 🙏 Thanks @b4handjr

@b4handjr b4handjr added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 471b3e4 Dec 19, 2024
16 checks passed
@b4handjr b4handjr deleted the fix-11972 branch December 19, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredlockhart jaredlockhart jaredlockhart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b4handjr @jaredlockhart