feat(nimbus): add audience form for new nimbus ui #11946
Conversation
jaredlockhart
requested review from
yashikakhurana and
brennie
as code owners
| @@ -643,6 +646,10 @@ def treatment_branches(self): | |||
| branches = branches.exclude(id=self.reference_branch.id) | |||
| return list(branches) | |||
|
|
|||
| @property | |||
| def is_desktop(self): | |||
There was a problem hiding this comment.
Maybe this should be application_is_desktop or similar
There was a problem hiding this comment.
Oh, could be, usually you start predicates like this with the verb so is_ can_ should_ etc, so it'd be more like is_application_desktop but I feel like desktop is only used in the context of the application so it seems unambiguous to me?
| @@ -41,6 +41,15 @@ | |||
| calc(0.75em + 0.375rem) calc(0.75em + 0.375rem); | |||
| } | |||
|
|
|||
| .bootstrap-select.is-invalid { | |||
There was a problem hiding this comment.
I know it's a hassle, bootstrap-select doesn't seem to style itself consistently with the other bootstrap5 elements so I gotta keep overriding it.
There was a problem hiding this comment.
Clean and nice changes, tested locally worked absolutely fine, thanks @jaredlockhart 🎉
| @@ -643,6 +646,10 @@ def treatment_branches(self): | |||
| branches = branches.exclude(id=self.reference_branch.id) | |||
| return list(branches) | |||
|
|
|||
| @property | |||
| def is_desktop(self): | |||
| return self.application == self.Application.DESKTOP | |||
There was a problem hiding this comment.
oh nice, we have couple of places in the code where we can use this property now
Because * We are implementing all the forms in HTMX * Time to do the audience form This commit * Adds the audience form to the new Nimbus UI fixes #10839
Because
This commit
fixes #10839