Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nimbus): add segments to new Nimbus UI summary page #11563

Merged
merged 2 commits into from
Oct 18, 2024
Merged

feat(nimbus): add segments to new Nimbus UI summary page #11563

merged 2 commits into from
Oct 18, 2024

Conversation

RJAK11
Copy link
Contributor

@RJAK11 RJAK11 commented Oct 17, 2024 •
edited
Loading

Because

  • We want to allow the user to view the selected segments on the new Nimbus UI summary page

This commit

  • Updates the new Nimbus UI summary page to display the selected segments with links to their definitions

Fixes #11533

image
image

@RJAK11
feat(nimbus): add segments to new Nimbus UI summary page
2f76f2e 
Because

* We want to allow the user to view the selected segments on the new Nimbus UI summary page

This commit

* Updates the new Nimbus UI summary page to display the selected segments with links to their definitions

Fixes #11533
@RJAK11 RJAK11 marked this pull request as ready for review October 18, 2024 14:49
@RJAK11 RJAK11 requested a review from mikewilli October 18, 2024 14:49
mikewilli
mikewilli approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@mikewilli mikewilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! I left the smallest of comments, but not too concerned about it -- up to you what you think is clearer syntax.

experimenter/experimenter/nimbus_ui_new/views.py Show resolved Hide resolved
@RJAK11
feat(nimbus): add segments to new Nimbus UI summary page
dfc8065 
Because

* We want to allow the user to view the selected segments on the new Nimbus UI summary page

This commit

* Updates the new Nimbus UI summary page to display the selected segments with links to their definitions

Fixes #11533
@RJAK11 RJAK11 added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 568526b Oct 18, 2024
17 checks passed
@RJAK11 RJAK11 deleted the segments-summary-11533 branch October 18, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikewilli mikewilli mikewilli approved these changes

@jaredlockhart jaredlockhart Awaiting requested review from jaredlockhart jaredlockhart is a code owner

@yashikakhurana yashikakhurana Awaiting requested review from yashikakhurana yashikakhurana is a code owner

@brennie brennie Awaiting requested review from brennie brennie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add segments to new Nimbus UI summary page
2 participants
@RJAK11 @mikewilli