Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nimbus): Update owner information for some Desktop features #11555

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

brennie
Copy link
Member

@brennie brennie commented Oct 16, 2024

Because:

  • the desktop feature manifest requires owner information;
  • we are switching to generating the desktop feature manifest in the schemas package; and
  • using that model to load our feature configurations was causing validation errors

this commit:

  • adds the missing ownership information to these schemas, which is fine because they will never be re-synced by manifesttool (as their versions are too old).

Fixes #11553

Because:

- the desktop feature manifest requires owner information;
- we are switching to generating the desktop feature manifest in the
  schemas package; and
- using that model to load our feature configurations was causing
  validation errors

this commit:

- adds the missing ownership information to these schemas, which is fine
  because they will never be re-synced by manifesttool (as their versions
  are too old).

Fixes #11553
Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@brennie brennie added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 90f792c Oct 16, 2024
17 checks passed
@brennie brennie deleted the dev/schemas/update-desktop-owners branch October 16, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix previously synced manifests that don't match the schema
2 participants