Fix based on review

mozilla · Oct 3, 2024 · b37b0e4 · b37b0e4
1 parent 2022b21
commit b37b0e4
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/bigquery_etl/cli/monitoring.py b/bigquery_etl/cli/monitoring.py
@@ -173,7 +173,7 @@ def update(name: str, sql_dir: Optional[str], project_id: Optional[str]) -> None
                                     ),
                                     metric_schedule=SimpleMetricSchedule(
                                         named_schedule=SimpleNamedSchedule(
-                                            name="Default Schedule - 17:00 UTC"
+                                            name="Default Schedule - 13:00 UTC"
                                         )
                                     ),
                                 )

diff --git a/sql/moz-fx-data-shared-prod/org_mozilla_fenix_derived/releases_v1/bigconfig.yml b/sql/moz-fx-data-shared-prod/org_mozilla_fenix_derived/releases_v1/bigconfig.yml
@@ -10,10 +10,10 @@ table_deployments:
         predefined_metric: FRESHNESS
       metric_schedule:
         named_schedule:
-          name: Default Schedule - 17:00 UTC
+          name: Default Schedule - 13:00 UTC
     - metric_type:
         type: PREDEFINED
         predefined_metric: VOLUME
       metric_schedule:
         named_schedule:
-          name: Default Schedule - 17:00 UTC
+          name: Default Schedule - 13:00 UTC
diff --git a/sql_generators/glean_usage/common.py b/sql_generators/glean_usage/common.py
@@ -15,7 +15,7 @@
 from bigquery_etl.schema.stable_table_schema import get_stable_table_schemas
 from bigquery_etl.util.common import get_table_dir, render, write_sql
 
-APP_LISTINGS_URL =  "https://probeinfo.telemetry.mozilla.org/v2/glean/app-listings"
+APP_LISTINGS_URL = "https://probeinfo.telemetry.mozilla.org/v2/glean/app-listings"
 PATH = Path(os.path.dirname(__file__))
 
 # added as the result of baseline checks being added to the template,

diff --git a/sql_generators/glean_usage/templates/baseline_clients_last_seen_v1.bigconfig.yml b/sql_generators/glean_usage/templates/baseline_clients_last_seen_v1.bigconfig.yml
@@ -3,18 +3,18 @@ table_deployments:
 - collection:
     name: Test
   deployments:
-  - fq_table_name: {{ project_id }}.{{ derived_dataset }}.{{ target_table }}
+  - fq_table_name: {{ project_id }}.{{ project_id }}.{{ derived_dataset }}.{{ target_table }}
     table_metrics:
     - metric_type:
         type: PREDEFINED
         predefined_metric: FRESHNESS
       metric_schedule:
         named_schedule:
-          name: Default Schedule - 17:00 UTC
+          name: Default Schedule - 13:00 UTC
     - metric_type:
         type: PREDEFINED
         predefined_metric: VOLUME
       metric_schedule:
         named_schedule:
-          name: Default Schedule - 17:00 UTC
+          name: Default Schedule - 13:00 UTC