-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experiment with running headless Firefox in parallel #115
base: main
Are you sure you want to change the base?
Conversation
1 similar comment
Interestingly, four processes introduced some failures. One build passed in 3.5 minutes, but the other had connection refused for several tests. I wonder if we're hitting the available port race condition. Let's leave this open for now. |
If we could get the geckodriver log files, we might be able to confirm the port clashing theory. |
1 similar comment
Seems like it was just esr that failed...I think geckodriver 18 recommends 53 and up now. Maybe We skip the auto runs on <53 ? I think we could do up to |
No, there was also a nightly job that failed.
FoxPuppet has committed to supporting Firefox ESR so it would seem we can't upgrade geckodriver for all versions. Perhaps we'll need to download an older version for ESR, but we should probably also mention that in the documentation. |
Seems easy enough with the new build steps |
@davehunt is there a way to just print the output of geckodriver.log at the very end of the job? Or maybe use S3 upload of built artifacts: https://docs.travis-ci.com/user/uploading-artifacts? |
Yeah, I'll take a look today.
This is my preference. I've set it up once before, so I'll look into it. |
You might not notice this for ESR only but also for release vs. beta, and central. So it might be a good idea to specify a release of geckodriver for a version of Firefox. With the release of 0.18 re recommend Firefox 54 and later. |
I've raised bug 1390311 to set up an S3 bucket for build artifacts. |
3 similar comments
See bug 1388465 for the potentially related issue. |
I've opened #146 to enable uploading artifacts to S3, however note that this not work for pull requests from other users due to the potential to expose AWS secrets. Once that has been merged we can rebase this and push to the main project to see the artifacts. |
d4a0f0f
to
b15a0af
Compare
Rebased and also pushed to https://github.com/mozilla/FoxPuppet/tree/heracles so we can see the artifacts at https://travis-ci.org/mozilla/FoxPuppet/builds/333932386 |
This change runs headless Firefox instances in parallel. Hydra had lots of heads running in parallel. Heracules made Hydra headless. Forgive me.
This is looking good! |
@jrbenny35 we're still seeing occaisional failures when Geckodriver attempts to connect to Firefox. It looks like Firefox isn't launching. I have at least ruled out a port clash now that we have additional logging enabled. I'm going to see if I can replicate on a debug build to investigate further. In the meantime, please don't merge this PR. |
@davehunt yeah I figured so, that is why I didn't merge it. |
This change runs headless Firefox instances in parallel.