Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1422: add BigQuery check to heartbeat #1516

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix #1422: add BigQuery check to heartbeat #1516

wants to merge 1 commit into from

Conversation

leplatrem
Copy link
Contributor

Fix #1422

@leplatrem leplatrem requested a review from a team as a code owner December 3, 2024 11:26
@leplatrem leplatrem added the enhancement New feature or request label Dec 3, 2024
alexcottner
alexcottner reviewed Dec 5, 2024
View reviewed changes
telescope/app.py

# Big Query
try:
checks["bigquery"] = (await utils.fetch_bigquery("SELECT 'ok';"))[0]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If bigquery is having an outage, this will also fail for us. Do we want this in our heartbeat because of that? Is there a way for us to check the exception to see if we received an auth error or a different error?

@leplatrem leplatrem marked this pull request as draft January 13, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcottner alexcottner alexcottner left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add BigQuery integration check in heartbeat
2 participants
@leplatrem @alexcottner