bug-1910613: update guidance on 429s and symbols zip archive sizes #2984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willkg
commented
Aug 2, 2024
| Upload by HTTP POST (payload < 2gb size) | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| Upload by HTTP POST | ||
| ~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
We no longer suggest picking one based on the size of the file. Instead we suggest breaking up large files into smaller ones regardless of the upload method.
willkg
commented
Aug 2, 2024
| payload and specify the url to the symbols file as a value to ``url``. | ||
|
|
||
| Domains that Tecken will download from is specified in the | ||
| ``DJANGO_ALLOW_UPLOAD_BY_DOWNLOAD_DOMAINS`` environment variable and at the | ||
| time of this writing is set to:: | ||
|
|
||
| queue.taskcluster.net | ||
| public-artifacts.taskcluster.net | ||
| firefox-ci-tc.services.mozilla.com |
There was a problem hiding this comment.
I updated this to match our settings.
willkg
commented
Aug 2, 2024
|
|
||
| Symbols files can not be overwritten. Once a file is uploaded, any future | ||
| upload attempts for that debug_filename/debug_id combination will be | ||
| skipped. |
There was a problem hiding this comment.
This was never true. This was a misunderstanding I had for a long time and should have fixed this ages ago.
relud
approved these changes
Aug 2, 2024
docs/upload.rst
Outdated
|
|
||
| .. Note:: | ||
|
|
||
| For retrying, we suggest waiting between 15 seconds between retry attempts. |
There was a problem hiding this comment.
seems like there's an extra "between" here
Suggested change
| For retrying, we suggest waiting between 15 seconds between retry attempts. | |
| For retrying, we suggest waiting 15 seconds between retry attempts. |
This updates the guidance on retrying to wait 15 seconds and try again. This also updates the discussion around which HTTP POST method to use in relation to the symbol zip archive size. We now recommend this new model where we encourage people to have symbol zip archive sizes < 2gb and they should split the archive up across multiple HTTP POSTs.
willkg
force-pushed
the
willkg-bug-1910613-429
branch
from
96486da to
eda6c35
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the guidance on retrying to wait 15 seconds and try again.
This also updates the discussion around which HTTP POST method to use in relation to the symbol zip archive size. We now recommend this new model where we encourage people to have symbol zip archive sizes < 2gb and they should split the archive up across multiple HTTP POSTs.