Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multilines mappings in backport_records #1508

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

leplatrem
Copy link
Contributor

@leplatrem leplatrem force-pushed the add-support-multiline-filters branch from d400185 to 605dfd6 Compare January 23, 2025 11:08
@alexcottner
Copy link

This is better (obviously). But it still means we need N rows of config for each collection we're copying to. Is it possible for us to support a little regex in here so as the collection grows we don't have to keep making changes? Ex:

main\/shops\?contains_regions=\["(\w+)"\] -> main-workspace/shops-$1

Copy link

@alexcottner alexcottner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a suggestion that could make this better (or at least let us update it less often). But this is still a good improvement so approving.

@leplatrem
Copy link
Contributor Author

But it still means we need N rows of config for each collection we're copying to. Is it possible for us to support a little regex in here so as the collection grows we don't have to keep making changes? Ex:

With the regexp approach, I don't understand how do you define the inputs.
The goal of this is not to breakdown automatically for each possible field value, but copy a subset of records from one source collection to another. We don't necessarily want a collection for each possible value (ex. bid/cid?country=us -> bid/cid-us, bid/cid?not_country=us -> bid/cid-world).

We sort of touched that topic in https://github.com/mozilla/remote-settings/pull/729/files#r1910743449

@leplatrem leplatrem merged commit 24adbf5 into master Jan 23, 2025
2 checks passed
@leplatrem leplatrem deleted the add-support-multiline-filters branch January 23, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants