Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eliot stage url #97

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Update eliot stage url #97

merged 2 commits into from
Nov 16, 2023

Conversation

willkg
Copy link
Contributor

@willkg willkg commented Nov 15, 2023

This updates the stage url for the service status script to the new Eliot webservices stage gke one.

You can run the script like this:

python bin/service-status.py

@willkg
Copy link
Contributor Author

willkg commented Nov 15, 2023

It's weird that there's lines like this in the PR history:

image

The language suggests something got deployed, but it didn't.

@willkg willkg merged commit 451a7ff into main Nov 16, 2023
1 check passed
@smarnach
Copy link
Contributor

GitHub Actions always writes that something has been "deployed" if you use an "environment" for a worklfow, since "environments" are meant to be used for deployments.

We are using environments to configure workload identity federation, so we can upload images to GAR without storing any actual secrets in GitHub. But once we do that, we get that weird language in PRs, and I don't think there's much we can do about this.

@willkg willkg deleted the update-stage-url branch January 11, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants