Switch to cavendish fakesentry image #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willkg
force-pushed
the
switch-fakesentry
branch
from
20bfe91 to
0c012f5
Compare
biancadanforth
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
LGTM
This pins the image to a particular release version of what's uploaded to cavendish's GAR by obs-common -- based on the obs-common changelog, there have been more recent releases that update this image (like a patch Python version update in https://github.com/mozilla-services/obs-common/releases/tag/v2025.01.02). What are your considerations for choosing this version (which fixes a broken image_repo_path) versus a more recent one?
|
Computing the line isn't easy so I copied it from one of the other repos. It'll get updated by dependabot next time that runs. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.