-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basti/kn intervention #10042
base: main
Are you sure you want to change the base?
basti/kn intervention #10042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple small nits, but looks good.
Holding off on approval until we have an r+ from a data steward. Let me know if you want me to get that process going - would be happy to pitch in on that.
src/webextensionadapter.cpp
Outdated
#include <qjsonarray.h> | ||
#include <qjsonobject.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't these already included on lines 11 and 13?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
truee, i have a new vscode addon that probably added that >:(
Co-authored-by: MCleinman <[email protected]>
DATA REVIEW REQUEST
We're trying to measure how many users are having Intels "Killer Network" software installed.
We want for a short period measure how many people are affected by this.
We did try to measure impact by observing web forums complaining about breakage, but the sample size is too small and skewed towards technical users.
No.
This collection is Glean so is documented in the Glean Dictionary.
This collection has expiry '2025-06-30'.
All channels, countries, and locales. No filters.
These collections are Glean. The opt-out can be found in the product's preferences.
We will use looker to check the results.
They will be shared internally with the team.
No. |
Taggging @travis79 for a data-review :) |
This Pr adds the most basic code needed to make sure we handle intels KN service.
For this i want to add a concept of "Interventions" as
3rdparty Software that interferes with us and therefore we intervene
. Hopefully, this will be an empty folder.For now let's add:
-> a detection for kn,
-> an API for the Extension to query detected interventions
-> Telemetry for kn, to make a rough case of how much we really should be focusing this on: should this just be a sumo article or do we really need to intervene.