Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basti/kn intervention #10042

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

basti/kn intervention #10042

wants to merge 6 commits into from

Conversation

strseb
Copy link
Collaborator

@strseb strseb commented Nov 14, 2024

This Pr adds the most basic code needed to make sure we handle intels KN service.

For this i want to add a concept of "Interventions" as 3rdparty Software that interferes with us and therefore we intervene. Hopefully, this will be an empty folder.

For now let's add:
-> a detection for kn,
-> an API for the Extension to query detected interventions
-> Telemetry for kn, to make a rough case of how much we really should be focusing this on: should this just be a sumo article or do we really need to intervene.

Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small nits, but looks good.

Holding off on approval until we have an r+ from a data steward. Let me know if you want me to get that process going - would be happy to pitch in on that.

src/interventions/killernetwork.h Outdated Show resolved Hide resolved
Comment on lines 7 to 8
#include <qjsonarray.h>
#include <qjsonobject.h>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these already included on lines 11 and 13?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

truee, i have a new vscode addon that probably added that >:(

@strseb
Copy link
Collaborator Author

strseb commented Nov 18, 2024

DATA REVIEW REQUEST

  1. What questions will you answer with this data?

We're trying to measure how many users are having Intels "Killer Network" software installed.
It is a traffic prioritization engine pre-installed on some OEM's, and it breaks the VPN Split tunnel and the VPN Extension.

  1. Why does Mozilla need to answer these questions? Are there benefits for users?

We want for a short period measure how many people are affected by this.
This will allow us to (them remove the probe) and formulate a solution.
A low impact count would just require a sumo article, a high impact count would make it valuable to notifiy the user about this breakage.

  1. What alternative methods did you consider to answer these questions?
    Why were they not sufficient?

We did try to measure impact by observing web forums complaining about breakage, but the sample size is too small and skewed towards technical users.

  1. Can current instrumentation answer these questions?

No.

  1. List all proposed measurements and indicate the category of data collection for each
    measurement, using the Firefox data collection categories found on the Mozilla wiki.
Measurement Name Measurement Description Data Collection Category Tracking Bug
sample.killer_network_detected The Conflicting Service 'Killer network' is detected technical https://mozilla-hub.atlassian.net/browse/VPN-6606
  1. Please provide a link to the documentation for this data collection which
    describes the ultimate data set in a public, complete, and accurate way.

This collection is Glean so is documented in the Glean Dictionary.

  1. How long will this data be collected?

This collection has expiry '2025-06-30'.

  1. What populations will you measure?

All channels, countries, and locales. No filters.

  1. If this data collection is default on, what is the opt-out mechanism for users?

These collections are Glean. The opt-out can be found in the product's preferences.

  1. Please provide a general description of how you will analyze this data.

We will use looker to check the results.

  1. Where do you intend to share the results of your analysis?

They will be shared internally with the team.

  1. Is there a third-party tool (i.e. not Glean or Telemetry) that you
    are proposing to use for this data collection?

No.

@strseb
Copy link
Collaborator Author

strseb commented Nov 18, 2024

Taggging @travis79 for a data-review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants