Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FXVPN-321 #169

Merged
merged 1 commit into from
Dec 23, 2024
Merged

FXVPN-321 #169

merged 1 commit into from
Dec 23, 2024

Conversation

lesleyjanenorton
Copy link
Member

@lesleyjanenorton lesleyjanenorton commented Dec 23, 2024

Fixes:

  • FXVPN-321 - "Get help broken for all error panels"
  • FXVPN-322 - "Subscribe now button does nothing"

Also:

  • Changes the CTA on the last onboarding screen from 'Next' to 'Done'
  • Hides 'skip' on the last onboarding screen

@lesleyjanenorton lesleyjanenorton requested review from mcleinman and removed request for strseb December 23, 2024 17:50
Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make sure I understand, the initial telemetry request has moved from an onboarding screen to new tab? (It's not what is in the mocks, so I want to confirm this wasn't some sort of regression.)

@lesleyjanenorton
Copy link
Member Author

To make sure I understand, the initial telemetry request has moved from an onboarding screen to new tab? (It's not what is in the mocks, so I want to confirm this wasn't some sort of regression.)

@mcleinman Exactly. This happened on Wednesday or Thursday of last week. New spec is here: https://www.figma.com/design/FixeQmo9NqzLa1sGtFWQ9s/Mozilla-VPN-Extension-Data-Collection-consent?node-id=8322-3458

Copy link
Collaborator

@mcleinman mcleinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

If we didn't want to lock that hidden onboarding button to onboarding screen 3 (and make it dynamic, so it works as expected if we add a 4th screen in the future), we could do something like this. Definitely not necessary - especially because creating an unseen space is not the best practice, certainly.

@lesleyjanenorton
Copy link
Member Author

I thought exactly the same thing but after ~20 minutes of attempting to add a class to that secondary action on the last onboarding panel I took the easy css way out.

@lesleyjanenorton lesleyjanenorton merged commit 40e326d into main Dec 23, 2024
5 checks passed
@lesleyjanenorton lesleyjanenorton deleted the fix-ctas branch December 23, 2024 22:05
lesleyjanenorton added a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants