Allow propertySum to consume any amount of properties #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,11 +42,11 @@ export class RequestHandler extends Component { | |||
| }); | |||
|
|
|||
| propertySum( | |||
There was a problem hiding this comment.
Very snazzy. I think we can tidy RequestHandler up nicely (in a future PR) by adding this.extState to this propertySum and consolidating handleExtensionStateChanges and updateProxyInfoFromClient.
strseb
force-pushed
the
basti/refactor_vargs_property_sum
branch
from
fa6f17f to
64b369b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
computedcan be created without a type, so let's remove the class backing it.In FXVPN-10: onboarding flow #142 Matt hit a thing where a sum of more then 2 elements is required, let's refactor propertySum to work with N elements, and add tests for it :)